Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

docs: blog post for v7#8400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bradzacher merged 3 commits intomainfromv7-blog-post
Feb 9, 2024
Merged

docs: blog post for v7#8400

bradzacher merged 3 commits intomainfromv7-blog-post
Feb 9, 2024

Conversation

bradzacher
Copy link
Member

PR Checklist

Overview

Adds a blog post for the v7 release to summarise the changes and announce our new package.

shinGangan reacted with hooray emojishinGangan reacted with eyes emoji
@bradzacherbradzacher added the documentationDocumentation ("docs") that needs adding/updating labelFeb 7, 2024
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedFeb 7, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit064a142
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/65c694f98214470008621253
😎 Deploy Previewhttps://deploy-preview-8400--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 99 (🟢 up 11 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedFeb 7, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit064a142. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 33 targets

Sent with 💌 fromNxCloud.

@codecovCodecov
Copy link

codecovbot commentedFeb 7, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base(8ef5f4b) 87.78% compared to head(064a142) 86.94%.
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@##             main    #8400      +/-   ##==========================================- Coverage   87.78%   86.94%   -0.84%==========================================  Files         397      252     -145       Lines       13821    12251    -1570       Branches     4067     3861     -206     ==========================================- Hits        12133    10652    -1481+ Misses       1391     1332      -59+ Partials      297      267      -30
FlagCoverage Δ
unittest86.94% <ø> (-0.84%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

see 147 files with indirect coverage changes

## Installation

```bash npm2yarn
npm i typescript-eslint
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

TS eslint is usually used as a dev tool. So would it make sense to instruct to install it with -D?

JoshuaKGoldberg reacted with thumbs up emoji
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good as a start! 🚀

Requesting changes on a bit more info.

@JoshuaKGoldbergJoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party labelFeb 7, 2024
@github-actionsgithub-actionsbot removed the awaiting responseIssues waiting for a reply from the OP or another party labelFeb 9, 2024
JoshuaKGoldberg
JoshuaKGoldberg previously approved these changesFeb 9, 2024
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🚀 Whoohoo!

This looks great, thanks for all the writing-up. I just left some small things inline - nothing blocking IMO.

Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
@bradzacherbradzacher merged commitf569553 intomainFeb 9, 2024
@bradzacherbradzacher deleted the v7-blog-post branchFebruary 9, 2024 21:25
@hyunbinseo
Copy link

Regarding the Node.js engine requirements:

Update Node.js engine requirement to^18.18.0 || >=20.0.0.
…
Note that this is the same requirement that ESLint v9 will impose.

"engines": {
"node":"^18.18.0 || >=20.0.0"
},

the ESLint team decided to use^18.18.0 || ^20.9.0.

This is because v20 LTS started fromv20.9.0.

https://nodejs.org/en/blog/release/v20.9.0

Either the blog post or thepackage.json should be updated?

@bradzacher
Copy link
MemberAuthor

Oh looks like I didn't copy past correctly.
Oh well - it's close enough really. If someone's on v20 it should be close to a no-op for them to upgrade to v20.9

With our next major well bump it properly.

hyunbinseo reacted with thumbs up emoji

@hyunbinseo
Copy link

Thanks for the confirmation.

I understand that it is a breaking change, but enforcing v20 LTS in a minor release seems viable.

@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsFeb 23, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JamesHenryJamesHenryJamesHenry left review comments

@rubiesontheskyrubiesontheskyrubiesonthesky left review comments

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg left review comments

Assignees
No one assigned
Labels
documentationDocumentation ("docs") that needs adding/updating
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

📣 Upcoming v7 Major Release
5 participants
@bradzacher@hyunbinseo@JamesHenry@rubiesonthesky@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp