typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.8k

feat(utils): revert removal of backwards-compat functions#8399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

bradzacher merged 1 commit intomainfromv7-add-back-utils

Feb 7, 2024

Merged

feat(utils): revert removal of backwards-compat functions#8399

bradzacher merged 1 commit intomainfromv7-add-back-utils

Feb 7, 2024

Conversation

Copy link

Member

bradzacher commentedFeb 7, 2024

Overview

Removed these in#8377 - but on second thought removing them is not goodright now.

Our goal for this next major is that users just bumpour peer dependencies (typescript and eslint). If we remove these functions then 3rd party plugins might break - meaning a user has to upgrade our peer deps AND 3rd party plugins. This isn't what we want - we want a isolated and painless major!

Adding them back and marking as@deprecated so that things keep working for now. We'll remove them in our next major.

feat(utils): revert removal of backwards-compat functions

4dd19da

bradzacher added the enhancementNew feature or request label

Feb 7, 2024

Copy link

Contributor

typescript-eslintbot commentedFeb 7, 2024

Thanks for the PR,@bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedFeb 7, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`4dd19da`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/65c2fa3ada2e7300088900db
😎 Deploy Preview	https://deploy-preview-8399--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 99 (🟢 up 11 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link

nx-cloudbot commentedFeb 7, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit4dd19da. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 33 targets

Sent with 💌 fromNxCloud.

Copy link

codecovbot commentedFeb 7, 2024

Codecov Report

Attention:6 lines in your changes are missing coverage. Please review.

Comparison is base(8ef5f4b) 87.78% compared to head(4dd19da) 86.94%.

Additional details and impacted files

@@            Coverage Diff             @@##             main    #8399      +/-   ##==========================================- Coverage   87.78%   86.94%   -0.84%==========================================  Files         397      252     -145       Lines       13821    12251    -1570       Branches     4067     3861     -206     ==========================================- Hits        12133    10652    -1481+ Misses       1391     1332      -59+ Partials      297      267      -30