Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(eslint-plugin): [prefer-string-starts-ends-with] add allowSingleElementEquality option#8374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Adds a newallowSingleElementEquality option to the rule that's allowed to be'never' (default) or'always'.

Doesn't yet add a third option for case matching as described in the issue. Is that ok to leave as a followup?

Also removes the auto-generation of tests fromprefer-string-starts-ends-with.test.ts per#6887. The test file predates that preference.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedFeb 4, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit1573b1c
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/65e79c6a8f3b8100089f6c72
😎 Deploy Previewhttps://deploy-preview-8374--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 90 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloud
Copy link

nx-cloudbot commentedFeb 4, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit1573b1c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

🟥 Failed Commands
nx run integration-tests:test
✅ Successfully ran 30 targets

Sent with 💌 fromNxCloud.

@JoshuaKGoldberg

This comment was marked as resolved.

@codecov
Copy link

codecovbot commentedFeb 22, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.14%. Comparing base(4c8b06d) to head(b9e88f0).

❗ Current headb9e88f0 differs from pull request most recent head1573b1c. Consider uploading reports for the commit1573b1c to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@##             main    #8374   +/-   ##=======================================  Coverage   87.13%   87.14%           =======================================  Files         251      251             Lines       12269    12272    +3       Branches     3869     3871    +2     =======================================+ Hits        10691    10694    +3  Misses       1306     1306             Partials      272      272
FlagCoverage Δ
unittest87.14% <100.00%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

FilesCoverage Δ
...plugin/src/rules/prefer-string-starts-ends-with.ts97.46% <100.00%> (+0.03%)⬆️
...s/eslint-plugin/src/util/collectUnusedVariables.ts93.13% <100.00%> (ø)

auvred
auvred previously approved these changesFeb 23, 2024
Copy link
Member

@auvredauvred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks great! 🔥

@JoshuaKGoldbergJoshuaKGoldberg merged commit32d8a8f intotypescript-eslint:mainMar 5, 2024
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsMar 14, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@bradzacherbradzacherbradzacher approved these changes

@auvredauvredauvred left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enhancement: [prefer-string-starts-ends-with] Option to ignore [0] === cases?

3 participants

@JoshuaKGoldberg@bradzacher@auvred
[8]ページ先頭
©2009-2025 Movatter.jp