43943d2: Pipes through aTOptions throughmeta.docs'sRuleMetaDataDocs type to allow aRuleRecommendationAcrossConfigs interface.
daa3513: Updates thegenerate:configs script to handle those options

Note that this is not a breaking change:

Existing values formeta.docs.recommended will still work, as the type is now a more permissive union
strict* configs explicitly indicate they can be modified as non-breaking changes

~~Sending as reference for triaging#7318.~~ ✅

feat(eslint-plugin): add meta.docs.recommended setting for strict con…

43943d2

…fig options

Copy link

Contributor

typescript-eslintbot commentedFeb 4, 2024

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedFeb 4, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`0e8aafa`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/65f6e0fbe3b73a00085fe80c
😎 Deploy Preview	https://deploy-preview-8364--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 96 (🟢 up 3 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

JoshuaKGoldberg mentioned this pull request

Feb 4, 2024

Configs: Allow strict configs to have more strict options than recommended?#7318

Closed

2 tasks

Copy link

nx-cloudbot commentedFeb 4, 2024•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit0e8aafa. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 fromNxCloud.

JoshuaKGoldberg added7 commits

February 4, 2024 09:31

Also updated generate:configs script

daa3513

Merge branch 'main'

d4491b8

fix: use recommended, not strict, in recommended configs

50ba30a

fix: no-floating-promises disables ignoreVoid in strict

98d1aa2

fix: no-floating-promises disables ignoreVoid in strict

60ef412

fix introduced build and lint issues

2c2f724

Fix configs.test.ts tests

df0bdfb

Copy link

codecovbot commentedMar 5, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.23%. Comparing base(994812b) to head(0e8aafa).

Additional details and impacted files

@@            Coverage Diff             @@##             main    #8364      +/-   ##==========================================- Coverage   88.02%   87.23%   -0.79%==========================================  Files         401      251     -150       Lines       13934    12334    -1600       Branches     4087     3881     -206     ==========================================- Hits        12265    10760    -1505+ Misses       1370     1305      -65+ Partials      299      269      -30

Flag	Coverage Δ
unittest	`87.23% <ø> (-0.79%)`	⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

Files	Coverage Δ
packages/eslint-plugin/src/rules/ban-ts-comment.ts	`97.29% <ø> (ø)`
...es/eslint-plugin/src/rules/no-floating-promises.ts	`100.00% <ø> (ø)`
.../eslint-plugin/src/rules/restrict-plus-operands.ts	`100.00% <ø> (ø)`
...-plugin/src/rules/restrict-template-expressions.ts	`100.00% <ø> (ø)`
packages/utils/src/eslint-utils/RuleCreator.ts	`75.00% <ø> (ø)`

... and150 files with indirect coverage changes

Merge branch 'main'

3bc01ee

Copy link

MemberAuthor

JoshuaKGoldberg commentedMar 5, 2024

I don't know why linting is failing in Nx Cloud but not for me locally. Fromhttps://github.com/typescript-eslint/typescript-eslint/actions/runs/8159357644/job/22303718471?pr=8364:

❌ > nx run eslint-plugin-internal:lint      Linting "eslint-plugin-internal"...     >  NX   _       Occurred while linting /home/runner/work/typescript-eslint/typescript-eslint/packages/eslint-plugin-internal/tests/rules/no-typescript-estree.test.ts:12     Rule: "@typescript-eslint/internal/plugin-test-formatting"    AtomicsWaitError: _  Occurred while linting /home/runner/work/typescript-eslint/typescript-eslint/packages/eslint-plugin-internal/tests/rules/no-typescript-estree.test.ts:12  Rule: "@typescript-eslint/internal/plugin-test-formatting"      at _Lock.lock (/home/runner/work/typescript-eslint/typescript-eslint/node_modules/make-synchronized/index.cjs:128:11)      at request (/home/runner/work/typescript-eslint/typescript-eslint/node_modules/make-synchronized/index.cjs:161:8)      at #sendActionToWorker (/home/runner/work/typescript-eslint/typescript-eslint/node_modules/make-synchronized/index.cjs:218:61)      at ThreadsWorker.sendAction (/home/runner/work/typescript-eslint/typescript-eslint/node_modules/make-synchronized/index.cjs:177:36)      at _Synchronizer.apply (/home/runner/work/typescript-eslint/typescript-eslint/node_modules/make-synchronized/index.cjs:297:25)      at Module.<anonymous> (/home/runner/work/typescript-eslint/typescript-eslint/node_modules/make-synchronized/index.cjs:303:40)      at prettierFormat (/home/runner/work/typescript-eslint/typescript-eslint/packages/eslint-plugin-internal/dist/rules/plugin-test-formatting.js:127:22)      at checkLiteral (/home/runner/work/typescript-eslint/typescript-eslint/packages/eslint-plugin-internal/dist/rules/plugin-test-formatting.js:177:32)      at checkExpression (/home/runner/work/typescript-eslint/typescript-eslint/packages/eslint-plugin-internal/dist/rules/plugin-test-formatting.js:162:21)      at checkValidTest (/home/runner/work/typescript-eslint/typescript-eslint/packages/eslint-plugin-internal/dist/rules/plugin-test-formatting.js:[364](https://github.com/typescript-eslint/typescript-eslint/actions/runs/8159357644/job/22303718471?pr=8364#step:5:399):25) >  NX   Nx Cloud: Cache miss 6517040724990785659.

cc@JamesHenry

JoshuaKGoldberg marked this pull request as ready for review

March 5, 2024 16:32

Copy link

Member

bradzacher commentedMar 5, 2024

@JoshuaKGoldberg thats the same intermittent thing I mentioned on discord the other day. It's something to do with the combination of nx +@prettier/sync, I think?

Copy link

MemberAuthor

JoshuaKGoldberg commentedMar 5, 2024

That sounds plausible to me!

bradzacher previously approved these changes

Mar 16, 2024

View reviewed changes

packages/utils/src/ts-eslint/Rule.ts

Comment on lines +11 to +16

		export interface RuleRecommendationAcrossConfigs<
		Options extends readonly unknown[],
		> {
		recommended: true;
		strict: Partial<Options>;
		}

Copy link

Member

bradzacherMar 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🤔 Part of me doesn't like that we're leaking our internal documentation implementation details into our public types.

I wonder if there's a way for us to privatise these types to avoid leaking them to users?

Copy link

MemberAuthor

JoshuaKGoldbergMar 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

That would be nice. I don't know though 😞 and it's already there.

Copy link

MemberAuthor

JoshuaKGoldbergMar 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Filed#8695.

bradzacher added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label

Mar 16, 2024

JoshuaKGoldberg added2 commits

March 17, 2024 08:07

Merge branch 'main' into meta-docs-recommended-strict

b8ecd76

Fix test conflict post-merge

0e8aafa

JoshuaKGoldberg dismissedbradzacher’sstale review via0e8aafa

March 17, 2024 12:24

JoshuaKGoldberg merged commitce79c55 intotypescript-eslint:main

Mar 17, 2024

JoshuaKGoldberg deleted the meta-docs-recommended-strict branch

March 17, 2024 14:35

This was referencedMar 17, 2024

Bug: RuleCreator leaks internal meta.docs, meta.type types#8695

Closed

Enhancement: [ban-types] Allow {} in the recommended config#8697

Closed

Docs: differences between recommended and strict configs not mentioned on the website#8712

Closed

fix(eslint-plugin): [no-floating-promises] revert disable of ignoreVoid in strict config#8718

Merged

llllvvuu reviewed

Mar 19, 2024

View reviewed changes

packages/eslint-plugin/src/rules/restrict-template-expressions.ts

		allowAny: false,
		allowBoolean: false,
		allowNullish: false,
		allowNumber: false,

Copy link

Contributor

llllvvuuMar 19, 2024•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

IsallowNumber: false intended? If so, should this doc be updated?

This rule reports on values used in a template literal string that aren't strings, numbers, or BigInts, optionally allowing other data types that provide useful stringification results.