Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(eslint-plugin): [no-unnecessary-type-assertion] provide valid fixes for assertions with extra tokens beforeas keyword#8326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JoshuaKGoldberg merged 2 commits intotypescript-eslint:mainfromauvred:fix/8325
Feb 3, 2024

Conversation

auvred
Copy link
Member

@auvredauvred commentedJan 31, 2024•
edited
Loading

PR Checklist

Overview

I think the test cases and comments are a nice overview :)

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@auvred!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedJan 31, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit331ed57
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/65ba70f06af49b000849f09e
😎 Deploy Previewhttps://deploy-preview-8326--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 99 (🟢 up 9 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@codecovCodecov
Copy link

codecovbot commentedJan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base(82cb9dd) 87.71% compared to head(331ed57) 87.73%.

Additional details and impacted files
@@            Coverage Diff             @@##             main    #8326      +/-   ##==========================================+ Coverage   87.71%   87.73%   +0.01%==========================================  Files         397      397                Lines       13948    13953       +5       Branches     4054     4055       +1     ==========================================+ Hits        12235    12241       +6  Misses       1401     1401+ Partials      312      311       -1
FlagCoverage Δ
unittest87.73% <100.00%> (+0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

FilesCoverage Δ
...-plugin/src/rules/no-unnecessary-type-assertion.ts97.56% <100.00%> (+1.45%)⬆️

Comment on lines +278 to +279
// < ( number ) > ( 3 + 5 )
// ^---remove---^
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldbergFeb 3, 2024•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

[Non-Actionable] Somehow my brain immediately parsed this as an emoticon smiley... amused.

< ( number ) >^---remove---^

auvred reacted with laugh emoji
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Very nice and thorough, awesome!

Animaniacs Pinky and the Brain: Pinky is saying "I love it. No notes!"

@JoshuaKGoldbergJoshuaKGoldberg merged commite2b46e0 intotypescript-eslint:mainFeb 3, 2024
danvk pushed a commit to danvk/typescript-eslint that referenced this pull requestFeb 4, 2024
…es for assertions with extra tokens before `as` keyword (typescript-eslint#8326)* fix(eslint-plugin): [no-unnecessary-type-assertion] provide valid fixes for assertions with extra tokens before `as` keyword* fix: provide fixes for angle bracket assertions when there're tokens inside
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsFeb 11, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [no-unnecessary-type-assertion] fixer produces syntax error when there are some extra tokens beforeas keyword
2 participants
@auvred@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp