Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
chore(eslint-plugin): [no-invalid-void-type] fixOptions typing to reflectminItems: 1#8312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Changes fromall commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -5,7 +5,7 @@ import { getSourceCode } from '@typescript-eslint/utils/eslint-utils'; | ||
| import { createRule } from '../util'; | ||
| interface Options { | ||
| allowInGenericTypeArguments?:[string, ...string[]] | boolean; | ||
Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. I suppose this makes sense technically 😄. But working with types like this can be irksome since you have to do it consistently. Is there an end-user reason for this change? I'm not opposed to it, just curious how it came up. ContributorAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Oh hi 😄. It's true that this isn't a random PR out of nowhere. I was reviewing my '@typescript-eslint/no-invalid-void-type'?:Linter.RuleEntry<[{allowInGenericTypeArguments?:string[]|boolean;allowAsThisParameter?:boolean;}]>; I checked
I figured that the out-of-date typing would affect DX for importrulesfrom'./rules';constaVar=rules['no-invalid-void-type'].create(/* ??? */); I felt I was in a bit too deep to be comfortable, so instead of figuring out how the Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Got it, makes sense. It looks like this is the only | ||
| allowAsThisParameter?: boolean; | ||
| } | ||