Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(eslint-plugin): [prefer-readonly] disable checking accessors#8300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

Jamesernator
Copy link
Contributor

@JamesernatorJamesernator commentedJan 25, 2024•
edited by JoshuaKGoldberg
Loading

PR Checklist

Overview

Accessors don't supportreadonly, so havingprefer-readonly apply to them doesn't make sense. The current behaviour also generates an invalid fix, as such this PR simply removes accessors from being considered in the rule.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@Jamesernator!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedJan 25, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit64267cd
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/65b7d5d9e32c1f00082ccc34
😎 Deploy Previewhttps://deploy-preview-8300--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 96 (🟢 up 6 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM for the quick fix, thanks! Your instincts were right in sending this PR along with the issue 😄 appreciated.

I've set a reminder for myself to apply the test splitup if you don't see it + have time before our Monday release.

@JoshuaKGoldbergJoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party labelJan 28, 2024
@JamesernatorJamesernator changed the titleDisable checking accessors for prefer-readonly[fix] Disable checking accessors for prefer-readonlyJan 28, 2024
@JamesernatorJamesernator changed the title[fix] Disable checking accessors for prefer-readonlyfix: Disable checking accessors for prefer-readonlyJan 28, 2024
@JamesernatorJamesernator changed the titlefix: Disable checking accessors for prefer-readonlyfix: [prefer-readonly] disable checking accessorsJan 28, 2024
@JoshuaKGoldbergJoshuaKGoldberg changed the titlefix: [prefer-readonly] disable checking accessorsfix(eslint-plugin): [prefer-readonly] disable checking accessorsJan 29, 2024
JoshuaKGoldberg
JoshuaKGoldberg previously approved these changesJan 29, 2024
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

💯 thanks!

@JoshuaKGoldbergJoshuaKGoldberg merged commit4d2ce3b intotypescript-eslint:mainJan 29, 2024
danvk pushed a commit to danvk/typescript-eslint that referenced this pull requestFeb 4, 2024
…escript-eslint#8300)* Disable checking accessors for prefer-readonly* Granular accessor tests* Update packages/eslint-plugin/src/rules/prefer-readonly.ts* fix: formatting and || for isModifierFlagSet suggestion---------Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsFeb 6, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg left review comments

Assignees
No one assigned
Labels
awaiting responseIssues waiting for a reply from the OP or another party
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [prefer-readonly] prefer-readonly should not consider accessors
2 participants
@Jamesernator@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp