Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(eslint-plugin): [class-literal-property-style] allow getter when same key setter exists#8277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bradzacher merged 5 commits intotypescript-eslint:mainfromyeonjuan:fix#5961
Feb 2, 2024

Conversation

yeonjuan
Copy link
Contributor

@yeonjuanyeonjuan commentedJan 20, 2024
edited
Loading

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedJan 20, 2024
edited
Loading

Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit9af90d0
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/65bc5ee9fd4f6400088df997
😎 Deploy Previewhttps://deploy-preview-8277--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95 (🟢 up 5 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@yeonjuanyeonjuan changed the titlefix(eslint-plugin): [class-literal-property-style] allow getter when …fix(eslint-plugin): [class-literal-property-style] allow getter when same key setter existsJan 20, 2024
@yeonjuanyeonjuanforce-pushed thefix#5961 branch 4 times, most recently from38a2136 to348267bCompareJanuary 28, 2024 04:09
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ithink there's an edge case that needs to be handled? But otherwise this looks good to me!

@JoshuaKGoldbergJoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party labelJan 28, 2024
@yeonjuanyeonjuanforce-pushed thefix#5961 branch 6 times, most recently from7c28999 toa4cb56fCompareJanuary 30, 2024 13:43
@github-actionsgithub-actionsbot removed the awaiting responseIssues waiting for a reply from the OP or another party labelJan 30, 2024
@yeonjuanyeonjuanforce-pushed thefix#5961 branch 4 times, most recently frome7e2b70 to819b411CompareFebruary 1, 2024 12:40
@codecovCodecov
Copy link

codecovbot commentedFeb 1, 2024
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base(5c253a8) 87.71% compared to head(9af90d0) 87.72%.

Additional details and impacted files
@@           Coverage Diff           @@##             main    #8277   +/-   ##=======================================  Coverage   87.71%   87.72%           =======================================  Files         397      397             Lines       13963    13971    +8       Branches     4061     4065    +4     =======================================+ Hits        12248    12256    +8  Misses       1403     1403             Partials      312      312
FlagCoverage Δ
unittest87.72% <100.00%> (+<0.01%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

FilesCoverage Δ
...t-plugin/src/rules/class-literal-property-style.ts100.00% <100.00%> (ø)

@JoshuaKGoldberg
Copy link
Member

Aside: could you please not force push PRs? It's a small thing, no worries, but fromhttps://typescript-eslint.io/contributing/pull-requests:

Reasoning: GitHub is not able to track changes across force pushes, which makes it take longer for us to perform incremental reviews

yeonjuan reacted with thumbs up emoji

JoshuaKGoldberg
JoshuaKGoldberg previously approved these changesFeb 1, 2024
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks great, thanks! 🔥

Just one suggested added test. I can merge this in too to get it in quickly.

#8323 tracks adding a shared utility around the static names. Linking in this comment for tracking.

@yeonjuan
Copy link
ContributorAuthor

Aside: could you please not force push PRs? It's a small thing, no worries, but fromhttps://typescript-eslint.io/contributing/pull-requests:

Oh OK! Sorry about that. I was making the review difficult. 😅

@JoshuaKGoldberg
Copy link
Member

No worries at all 😄 TIL I (re-)learned thatgh pr checkout has a--force.

@JoshuaKGoldbergJoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelFeb 1, 2024
@yeonjuan
Copy link
ContributorAuthor

yeonjuan commentedFeb 1, 2024
edited
Loading

@JoshuaKGoldberg
Copy link
Member

I don't know how that comment got hidden - but, yes - could you take a look please actually?

(I'm between things atm)

@yeonjuan
Copy link
ContributorAuthor

yeonjuan commentedFeb 1, 2024
edited
Loading

@JoshuaKGoldberg I made a pr for fixing it (#8336)
I thinks the lint error was false positive of no-unnecessary-condition. And the false positive fixed in#8249.

@bradzacherbradzacher merged commit69bd501 intotypescript-eslint:mainFeb 2, 2024
danvk pushed a commit to danvk/typescript-eslint that referenced this pull requestFeb 4, 2024
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsFeb 10, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@auvredauvredauvred left review comments

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg left review comments

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [class-literal-property-style] A literal getter with a setter does not pass lint, and incorrectly auto-fix
4 participants
@yeonjuan@JoshuaKGoldberg@auvred@bradzacher

[8]ページ先頭

©2009-2025 Movatter.jp