Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(eslint-plugin): [no-unused-vars] don't report on types referenced in export assignment expression#8265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JoshuaKGoldberg merged 1 commit intotypescript-eslint:mainfromauvred:fix/6383
Jan 29, 2024

Conversation

@auvred
Copy link
Member

PR Checklist

Overview

Explicitly visitTSExportAssignment's expression, so if it contains some type, that type gets a new reference

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@auvred!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedJan 17, 2024
edited
Loading

Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit8b6c1ce
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/65a7b2d9ac170a0008e800e7
😎 Deploy Previewhttps://deploy-preview-8265--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 94 (🔴 down 3 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, thanks! 🚀

Will leave open with the1 approval label in case another team member has time to review before the Monday release. Scope analysis can be tricky.

@JoshuaKGoldbergJoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelJan 17, 2024
@Josh-Cena
Copy link
Member

I don't have experience with the scope analyzer, but if the tests are passing it LGTM.

JoshuaKGoldberg reacted with rocket emoji

@bradzacher
Copy link
Member

bradzacher commentedFeb 1, 2024
edited
Loading

It looks like this introduced a regression intoconsistent-type-imports.

importtypeFoofrom'foo';// Type import "Foo" is used by decorator metadataexport={}asFoo;

filed#8330

danvk pushed a commit to danvk/typescript-eslint that referenced this pull requestFeb 4, 2024
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsFeb 9, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees

No one assigned

Labels

1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: [@typescript-eslint/no-unused-vars] False positive on export-equals syntax

4 participants

@auvred@Josh-Cena@bradzacher@JoshuaKGoldberg

[8]ページ先頭

©2009-2025 Movatter.jp