typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.8k

feat(eslint-plugin): [member-ordering] allow easy reuse of the default ordering#8248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

bradzacher merged 4 commits intotypescript-eslint:mainfromparloti:main

Jan 28, 2024

Merged

feat(eslint-plugin): [member-ordering] allow easy reuse of the default ordering#8248

bradzacher merged 4 commits intotypescript-eslint:mainfromparloti:main

Jan 28, 2024

Conversation

Copy link

Contributor

parloti commentedJan 14, 2024

PR Checklist

Addresses an existing open issue:fixesEnhancement:member-ordering default configuration #5452
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

This PR allows to customize themember-ordering rule, while maintaining the default member groups without having to copy and paste more than 100 lines of code.
The PR changes the way that the default settings is specified by causing these to be merged with the custom settings rather than replaced.

parloti added2 commits

January 13, 2024 22:16

fix(eslint-plugin): member-ordering default configuration (typescript…

ea6c303

…-eslint#5452)

Merge branch 'typescript-eslint:main' into main

a7b95dc

Copy link

Contributor

typescript-eslintbot commentedJan 14, 2024

Thanks for the PR,@parloti!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedJan 14, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`445be6f`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/65acebfeae12690008578336
😎 Deploy Preview	https://deploy-preview-8248--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 91 (🔴 down 6 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

parloti added2 commits

January 18, 2024 16:20

Merge branch 'main' into main

4028ef7

Merge branch 'main' into main

445be6f

bradzacher added the bugSomething isn't working label

Jan 28, 2024

bradzacher approved these changes

Jan 28, 2024

View reviewed changes

Copy link

Member

bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

thanks for doing this!

bradzacher changed the title~~fix(eslint-plugin): member-ordering default configuration~~feat(eslint-plugin): allow reuse of the default ordering without having to copy it

Jan 28, 2024

bradzacher added enhancementNew feature or request and removed bugSomething isn't working labels

Jan 28, 2024

bradzacher changed the title~~feat(eslint-plugin): allow reuse of the default ordering without having to copy it~~feat(eslint-plugin): [member-ordering] allow easy reuse of the default ordering

Jan 28, 2024

bradzacher merged commitbbc6770 intotypescript-eslint:main

Jan 28, 2024

danvk pushed a commit to danvk/typescript-eslint that referenced this pull request

Feb 4, 2024