Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
fix(eslint-plugin): [no-unnecessary-condition] fix false positive for type variable#8235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Thanks for the PR,@yeonjuan! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. |
netlifybot commentedJan 10, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
✅ Deploy Preview fortypescript-eslint ready!
To edit notification comments on pull requests, go to yourNetlify site configuration. |
d7befe4 tob7741f8CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This looks great to me, thanks for the fix!
Just one note on testing, but I'm happy to merge as-is or make the cleanup myself given that the tests for this rule already do the "test a lot in one case" thing.
Uh oh!
There was an error while loading.Please reload this page.
| function foo<T extends object>(arg: T, key: keyof T): void { | ||
| const t1 = arg[key] == null; | ||
| const t2 = null == arg[key]; | ||
| const t3 = arg[key] != null; | ||
| const t4 = null != arg[key]; | ||
| const t5 = arg[key] == undefined; | ||
| const t6 = undefined == arg[key]; | ||
| const t7 = arg[key] != undefined; | ||
| const t8 = undefined != arg[key]; | ||
| const t9 = arg[key] === null; | ||
| const t10 = null === arg[key]; | ||
| const t11 = arg[key] !== null; | ||
| const t12 = null !== arg[key]; | ||
| const t13 = arg[key] === undefined; | ||
| const t14 = undefined === arg[key]; | ||
| const t15 = arg[key] !== undefined; | ||
| const t16 = undefined !== arg[key]; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| functionfoo<Textendsobject>(arg:T,key:keyofT):void{ | |
| constt1=arg[key]==null; | |
| constt2=null==arg[key]; | |
| constt3=arg[key]!=null; | |
| constt4=null!=arg[key]; | |
| constt5=arg[key]==undefined; | |
| constt6=undefined==arg[key]; | |
| constt7=arg[key]!=undefined; | |
| constt8=undefined!=arg[key]; | |
| constt9=arg[key]===null; | |
| constt10=null===arg[key]; | |
| constt11=arg[key]!==null; | |
| constt12=null!==arg[key]; | |
| constt13=arg[key]===undefined; | |
| constt14=undefined===arg[key]; | |
| constt15=arg[key]!==undefined; | |
| constt16=undefined!==arg[key]; | |
| } | |
| functionfoo<Textendsobject>(arg:T,key:keyofT):void{ | |
| arg[key]==null; | |
| } |
| function foo<T extends object>(arg: T, key: keyof T): void { | ||
| arg[key] ??= 'default'; | ||
| arg[key] ||= 'default'; | ||
| arg[key] &&= 'default'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| functionfoo<Textendsobject>(arg:T,key:keyofT):void{ | |
| arg[key]??='default'; | |
| arg[key]||='default'; | |
| arg[key]&&='default'; | |
| functionfoo<Textendsobject>(arg:T,key:keyofT):void{ | |
| arg[key]??='default'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
💯 looks great, thanks as always!
PR Checklist
Overview
Fix the following false positive cases.