Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: fix test formatting in prefer-readonly.test.ts#8223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg commentedJan 8, 2024
edited
Loading

PR Checklist

Overview

Manually formats the failing snippets.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedJan 8, 2024
edited
Loading

Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit7868680
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/659c3a7c76731b0008435553
😎 Deploy Previewhttps://deploy-preview-8223--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 88 (🔴 down 11 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@JoshuaKGoldberg
Copy link
MemberAuthor

😬 surely we're not still being throttled from the accessibility-alt-text-bot thing...

Screenshot of six workflows queued, from as long ago as 30 minutes

@JoshuaKGoldberg
Copy link
MemberAuthor

Well I ran thisyarn lint andyarn test locally. All is well. I'll just merge now to get the release going.

@JoshuaKGoldbergJoshuaKGoldberg merged commit78db0ad intotypescript-eslint:mainJan 8, 2024
@JoshuaKGoldbergJoshuaKGoldberg deleted the prefer-readonly-test-formatting branchJanuary 8, 2024 18:46
@JoshuaKGoldberg
Copy link
MemberAuthor

Oh, dangit, this fixed#8222. Not#8220.

Things are not going well for me today 🙃

@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJan 16, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: release script breaks on call to yargs.version(false)
1 participant
@JoshuaKGoldberg

[8]ページ先頭

©2009-2025 Movatter.jp