Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

docs: underline URLs#8217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
lucas-amberg wants to merge5 commits intotypescript-eslint:mainfromlucas-amberg:main
Closed

docs: underline URLs#8217

lucas-amberg wants to merge5 commits intotypescript-eslint:mainfromlucas-amberg:main

Conversation

@lucas-amberg
Copy link
Contributor

PR Checklist

Overview

Added underlines to all URLs on the documentation and took steps to verify everything worked as usual.

fisker reacted with thumbs up emoji
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@lucas-amberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedJan 8, 2024
edited
Loading

Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit2f4f7c1
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/659bc0ff4d0a3a00082c3bf5
😎 Deploy Previewhttps://deploy-preview-8217--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Comment on lines -14 to +15
Please read our[Code of Conduct](https://github.com/typescript-eslint/typescript-eslint/blob/main/CODE_OF_CONDUCT.md) first.
If you're new to open source, you may also find the[How to Contribute to Open Source](https://opensource.guide/how-to-contribute) guide fromhttps://opensource.guide useful.
Please read our<u>[Code of Conduct](https://github.com/typescript-eslint/typescript-eslint/blob/main/CODE_OF_CONDUCT.md)</u> first.
If you're new to open source, you may also find the<u>[How to Contribute to Open Source](https://opensource.guide/how-to-contribute)</u> guide from<u>https://opensource.guide</u> useful.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

[just asking] Oh, this approach would require us to remember to always wrap any links in our docs in a<u> tag. Maybe we should underline them with css only?text-decoration: underline should do the trick

Moreover, I suppose we might want links in blog posts to be underlined too. I think it would be much easier to maintain if the underline was added automatically

So I guess we can just applytext-decoration to all links inside blog/docs container. Or vice-versa - apply underline to alla tags on the page and disabletext-decoration in undesirable places like the side bar or table of content

What do you think?

lucas-amberg reacted with thumbs up emoji
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Perhaps Docusaurus even has some functionality to customize markdown links (though I haven't searched)

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I definitely agree, I'm new to the MDX format and I was unsure how styling was applied in these pages in the first place aside from general markdown syntax.

Should be a fairly easy fix, I'll get it done in the morning.

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldbergJan 8, 2024
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yup, what@auvred said - we're definitely going to forget this if we need to do it manually. And it's a bit of a pain. There should be a way to apply a straightforward style for most or all of the links inside markdown content.

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for starting! What auvred said on making this more automatic.

@JoshuaKGoldbergJoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party labelJan 8, 2024
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJan 16, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@auvredauvredauvred requested changes

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg requested changes

Assignees

No one assigned

Labels

awaiting responseIssues waiting for a reply from the OP or another party

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Website accessibility: links not distinguishable without relying on color

3 participants

@lucas-amberg@JoshuaKGoldberg@auvred

[8]ページ先頭

©2009-2025 Movatter.jp