typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.8k

feat(eslint-plugin): add rule prefer-find#8216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 15 commits intotypescript-eslint:mainfromkirkwaiblinger:prefer-find

Feb 3, 2024

Merged

feat(eslint-plugin): add rule prefer-find#8216

JoshuaKGoldberg merged 15 commits intotypescript-eslint:mainfromkirkwaiblinger:prefer-find

Feb 3, 2024

Conversation

Copy link

Member

kirkwaiblinger commentedJan 8, 2024•
edited
Loading

PR Checklist

Addresses an existing open issue:fixesRule proposal: Preferring .find(...) over .filter(...)[0] #6886
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

Adds a rule that prefersarr.find(...) overarr.filter(...)[0]. Also adds the corresponding autofix as suggestions.

Copy link

Contributor

typescript-eslintbot commentedJan 8, 2024

Thanks for the PR,@kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedJan 8, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`b3e6db3`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/65bd1b939870fb0008e6d1c9
😎 Deploy Preview	https://deploy-preview-8216--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 95 (🟢 up 5 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

kirkwaiblinger force-pushed theprefer-find branch from2a7e8b4 to89cc74eCompare

January 8, 2024 19:51

JoshuaKGoldberg requested changes

Jan 9, 2024

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

A solid start, thanks for sending this in! Left some requests around edge cases to work on. Have fun 😄

packages/eslint-plugin/docs/rules/prefer-find.md OutdatedShow resolvedHide resolved

packages/eslint-plugin/src/rules/prefer-find.ts OutdatedShow resolvedHide resolved

packages/eslint-plugin/src/rules/prefer-find.tsShow resolvedHide resolved

packages/eslint-plugin/src/rules/prefer-find.ts OutdatedShow resolvedHide resolved

packages/eslint-plugin/tests/rules/prefer-find.test.tsShow resolvedHide resolved

JoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party label

Jan 9, 2024

kirkwaiblinger force-pushed theprefer-find branch fromae77c56 to526b73aCompare

January 13, 2024 04:43

kirkwaiblinger requested a review fromJoshuaKGoldberg

January 13, 2024 07:10

github-actionsbot removed the awaiting responseIssues waiting for a reply from the OP or another party label

Jan 13, 2024

bradzacher added the enhancement: new plugin ruleNew rule request for eslint-plugin label

Jan 28, 2024

JoshuaKGoldberg reviewed

Jan 30, 2024

View reviewed changes

packages/eslint-plugin/src/rules/prefer-find.ts OutdatedShow resolvedHide resolved

StyleShit suggested changes

Jan 30, 2024

View reviewed changes

packages/eslint-plugin/src/rules/prefer-find.ts OutdatedShow resolvedHide resolved

JoshuaKGoldberg requested changes

Jan 30, 2024

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is looking fantastic! Left a few comments, but mostly just nitpicks. Really happy about the implementation.☺️

I think the only remaining blocker is the0n bigint tests?

packages/eslint-plugin/src/rules/prefer-find.tsShow resolvedHide resolved

packages/eslint-plugin/src/rules/prefer-find.ts OutdatedShow resolvedHide resolved

packages/eslint-plugin/src/rules/prefer-find.tsShow resolvedHide resolved

packages/eslint-plugin/src/rules/prefer-find.ts OutdatedShow resolvedHide resolved

packages/eslint-plugin/tests/rules/prefer-find.test.ts OutdatedShow resolvedHide resolved

packages/eslint-plugin/tests/rules/prefer-find.test.tsShow resolvedHide resolved

packages/eslint-plugin/src/rules/prefer-find.ts OutdatedShow resolvedHide resolved

JoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party label

Jan 30, 2024

JoshuaKGoldberg previously approved these changes

Jan 30, 2024

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Wait sorry, (as you pointed out in Twitch chat), the0ns are there! I just missed them!

So I think it's just a few nitpicky comments from me left. I'll set a reminder to merge before our next release if you don't have time or interest for them.

JoshuaKGoldberg added 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge and removed awaiting responseIssues waiting for a reply from the OP or another party labels

Jan 30, 2024

kirkwaiblinger dismissedJoshuaKGoldberg’sstale review via581e9ae

January 30, 2024 21:43

kirkwaiblinger mentioned this pull request

Jan 30, 2024

Repo: Make utility for static member access#8323

Closed

kirkwaiblinger requested review fromStyleShit andJoshuaKGoldberg

January 30, 2024 22:30

auvred requested changes

Jan 31, 2024

View reviewed changes

packages/eslint-plugin/docs/rules/prefer-find.md OutdatedShow resolvedHide resolved

packages/eslint-plugin/src/rules/prefer-find.ts OutdatedShow resolvedHide resolved

packages/eslint-plugin/src/rules/prefer-find.tsShow resolvedHide resolved

kirkwaiblinger requested a review fromauvred

January 31, 2024 17:27

Copy link

Member

auvred commentedJan 31, 2024

auvred approved these changes

Jan 31, 2024

View reviewed changes

kirkwaiblinger added6 commits

February 2, 2024 09:38

Add rule prefer-find

57befc5

address lots of stuff

23933e6

remove console statement

7637266

tweaks

1ab0477

extract fix to function

26a3d69

improve behavior around nulls

eb90e11

kirkwaiblingerand others added9 commits

February 2, 2024 09:39

add comments around array indexing checks

8d74e43

messages were backwards

6fb63d8

filter syntax

8ac6fdd

formatting

9f39e63

add extra comma operator test

3b4a611

pr feedback round 2

702116c

Fix the the

a2a832d

Co-authored-by: auvred <61150013+auvred@users.noreply.github.com>

fix up imports

c5442c0

address intersections of arrays

b3e6db3

kirkwaiblinger force-pushed theprefer-find branch frome24bf60 tob3e6db3Compare

February 2, 2024 16:42

kirkwaiblinger mentioned this pull request

Feb 2, 2024

Repo: Internal linter rule for absolute imports from eslint packages#8345

Closed

kirkwaiblinger closed this

Feb 2, 2024

kirkwaiblinger reopened this

Feb 2, 2024

JoshuaKGoldberg approved these changes

Feb 3, 2024

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

JoshuaKGoldberg merged commit3bbb78d intotypescript-eslint:main

Feb 3, 2024

danvk pushed a commit to danvk/typescript-eslint that referenced this pull request

Feb 4, 2024

feat(eslint-plugin): add rule prefer-find (typescript-eslint#8216)

0498cfa

* Add rule prefer-find* address lots of stuff* remove console statement* tweaks* extract fix to function* improve behavior around nulls* add comments around array indexing checks* messages were backwards* filter syntax* formatting* add extra comma operator test* pr feedback round 2* Fix the theCo-authored-by: auvred <61150013+auvred@users.noreply.github.com>* fix up imports* address intersections of arrays---------Co-authored-by: auvred <61150013+auvred@users.noreply.github.com>

kirkwaiblinger mentioned this pull request

Feb 5, 2024

Bug: [prefer-find] Add support for checking ternaries#8379

Closed

4 tasks

github-actionsbot locked asresolvedand limited conversation to collaborators

Feb 11, 2024

kirkwaiblinger deleted the prefer-find branch

February 21, 2024 21:06