Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore(website): bump Docusaurus to v3#8209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg commentedJan 7, 2024
edited
Loading

PR Checklist

Overview

  • Bumping relevant packages to latest versions
  • yarn start starting the local dev server
  • Tabs plugin: switched to manual<Tabs> &<TabsItem>s
  • TypeScript config
  • No TypeScript type checking errors
  • No ESLint linting errors
  • No Markdownlint linting errors
  • Stricter parsing of generated.md files
  • Passing Docusaurus build
  • No Docusaurus build lint complaints (exceptlinking to /play#...)
  • Custom MDX components in internal plugins
  • Investigate any new warnings

auvred reacted with thumbs up emojiauvred reacted with hooray emoji
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedJan 7, 2024
edited
Loading

Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitf749c17
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/65f7040596de7000081a1cc9
😎 Deploy Previewhttps://deploy-preview-8209--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (🟢 up 5 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@auvredauvred mentioned this pull requestJan 8, 2024
26 tasks
@bradzacherbradzacher added awaiting responseIssues waiting for a reply from the OP or another party package: websiteIssues related to the @typescript-eslint website labelsFeb 20, 2024
@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedFeb 21, 2024
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitf749c17. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx test eslint-plugin --coverage=false
nx test ast-spec --coverage=false
nx test ast-spec
✅ Successfully ran 16 targets

Sent with 💌 fromNxCloud.

@JoshuaKGoldbergJoshuaKGoldberg requested review fromJosh-Cena and removed request forJosh-CenaFebruary 21, 2024 19:46
@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as ready for reviewFebruary 21, 2024 19:46
@JoshuaKGoldbergJoshuaKGoldberg removed the awaiting responseIssues waiting for a reply from the OP or another party labelFeb 21, 2024
@codecovCodecov
Copy link

codecovbot commentedMar 5, 2024
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.74%. Comparing base(ce79c55) to head(947d034).
Report is 1 commits behind head on main.

❗ Current head947d034 differs from pull request most recent headf749c17. Consider uploading reports for the commitf749c17 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@##             main    #8209      +/-   ##==========================================+ Coverage   87.23%   87.74%   +0.51%==========================================  Files         251      398     +147       Lines       12334    13827    +1493       Branches     3881     4067     +186     ==========================================+ Hits        10760    12133    +1373- Misses       1305     1397      +92- Partials      269      297      +28
FlagCoverage Δ
unittest87.74% <ø> (+0.51%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

see 230 files with indirect coverage changes

bradzacher
bradzacher previously approved these changesMar 16, 2024
Copy link
Member

@bradzacherbradzacher left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

quickly clicking around it looks like things are (at least mostly) working - so I'm happy for you to merge this whenever you get CI passing!
I trust you to do the last of the work to get this finished :)
Worst case we can always follow up with some patches if we miss something.

JoshuaKGoldberg reacted with rocket emoji
@bradzacherbradzacher added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelMar 16, 2024
@JoshuaKGoldberg
Copy link
MemberAuthor

ast-spec's test failures aren't related to this branch. This PR doesn't touchpackages/ast-spec,packages/typescript-estree,packages/utils, or non-md(x)/*.test.* files inpackages/eslint-plugin.

 $ git diff main | grep "diff --git" | grep -v ".tsx" | grep -v ".md" | grep -v "packages/website"diff --git a/packages/eslint-plugin/tests/docs.test.ts b/packages/eslint-plugin/tests/docs.test.tsdiff --git a/packages/repo-tools/src/generate-contributors.mts b/packages/repo-tools/src/generate-contributors.mtsdiff --git a/yarn.lock b/yarn.lock

Merging so I don't have to keep dealing with merge failures. If there's a snapshot failure on main afterwards I'll take a look. 🤘

@JoshuaKGoldbergJoshuaKGoldberg merged commit8640908 intotypescript-eslint:mainMar 17, 2024
@JoshuaKGoldbergJoshuaKGoldberg deleted the docusaurus-3 branchMarch 17, 2024 15:15
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsMar 25, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@slorberslorberslorber left review comments

@bradzacherbradzacherbradzacher left review comments

@Josh-CenaJosh-CenaAwaiting requested review from Josh-Cena

Assignees

@JoshuaKGoldbergJoshuaKGoldberg

Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we mergepackage: websiteIssues related to the @typescript-eslint website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Website: Bump to Docusaurus v3
4 participants
@JoshuaKGoldberg@slorber@bradzacher@Josh-Cena

[8]ページ先頭

©2009-2025 Movatter.jp