Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: rename release.ts to release.mts#8204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

ESLint was unhappy with the idea of renamingtools/release/release.ts torelease.mts becausetsconfig.eslint.json doesn't allow including.mts files.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedJan 6, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitdc7d962
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/659acc43305c4f0008fcfa1d
😎 Deploy Previewhttps://deploy-preview-8204--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 87 (🔴 down 12 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link
Member

@auvredauvred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Fun fact:jest.preset.js listed at the bottom oftsconfig.eslint.json has been deleted in08ae2c41d, perhaps we can remove it from tsconfig?

JoshuaKGoldberg reacted with thumbs up emoji
bradzacher
bradzacher previously approved these changesJan 7, 2024
Copy link
Member

@JamesHenryJamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

My point was addressed, but@auvred's seems to be important

Co-authored-by: auvred <61150013+auvred@users.noreply.github.com>
@JoshuaKGoldbergJoshuaKGoldberg merged commit958feca intotypescript-eslint:mainJan 7, 2024
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJan 15, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JamesHenryJamesHenryJamesHenry approved these changes

@auvredauvredauvred approved these changes

@bradzacherbradzacherbradzacher left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@JoshuaKGoldberg@JamesHenry@bradzacher@auvred
[8]ページ先頭
©2009-2025 Movatter.jp