Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
chore: the big package renaming#82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
codecovbot commentedJan 19, 2019 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
| @@ -40,7 +40,7 @@ ruleTester.run('tslint/config', rules.config, { | |||
| valid: [ | |||
| { | |||
| code: 'var foo = true;', | |||
| parser: 'typescript-eslint-parser', | |||
| parser: '@typescript-eslint/parser', | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
can you move parser and parserOptions to
construleTester=newRuleTester();
construleTester=newRuleTester({parserOptions:{ecmaVersion:6,sourceType:'module',ecmaFeatures:{}},parser:'@typescript-eslint/parser',project:'./tests/tsconfig.json'});
| // their work around exposing the parser. They may require that there be a project config field in | ||
| // the eslint config, in which case we should check and/or report that here appropriately. | ||
| throw new Error( | ||
| 'This rule requires you to use `eslint-plugin-typescript/parser`.' | ||
| 'This rule requires you to use `@typescript-eslint/eslint-plugin/parser`.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| 'This rule requires you to use `@typescript-eslint/eslint-plugin/parser`.' | |
| `You must provide a value for the "parserOptions.project" property for@typescript-eslint/parser` |
its same message as in plugin-tslint
@armano2 Thanks I've noted down your points, adding them to my follow up PR - lots of tweaks to make yet anyway and I don't want anyone starting any WIP without the big reorg/renaming |
Consolidate everything under their new scoped names, yes this is unreviewable, but fortunately it is a one-off! :)
Better docs will follow after this before 1.0.0 tomorrow