Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore(typescript-estree): remove unnecessary old snapshots#8198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

auvred
Copy link
Member

PR Checklist

Overview

It looks liked50942c was lost in thev6 merge

Removing'./tests/ast-alignment/spec\\.ts$' and'./tests/[^/]+\\.test\\.ts$' test include regexes, since these files were deleted inhttps://github.com/typescript-eslint/typescript-eslint/commit/fb799e7a8.patch

 delete mode 100644 packages/typescript-estree/tests/ast-alignment/fixtures-to-test.ts delete mode 100644 packages/typescript-estree/tests/ast-alignment/parse.ts delete mode 100644 packages/typescript-estree/tests/ast-alignment/spec.ts delete mode 100644 packages/typescript-estree/tests/ast-alignment/utils.ts delete mode 100644 packages/typescript-estree/tests/ast-fixtures.test.ts

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@auvred!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedJan 6, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit3face06
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/659926881c7f4e0008abca1d
😎 Deploy Previewhttps://deploy-preview-8198--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 89 (🔴 down 9 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@auvredauvred changed the titleChore/ts estree remove unnecessary old snapshotschore(typescript-estree): remove unnecessary old snapshotsJan 6, 2024
@auvredauvred mentioned this pull requestJan 6, 2024
26 tasks
@bradzacher
Copy link
Member

The GH app breaks on this PR so I can't actually stamp it... But the idea is sound.

JoshuaKGoldberg reacted with laugh emoji

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

😁 ridiculous. I love it. This is going to do wonders for your repo contribution stats.

Screenshot of the pull request's +1 -420,967 diff count

Thanks!

@JoshuaKGoldbergJoshuaKGoldberg merged commit635bb1f intotypescript-eslint:mainJan 8, 2024
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJan 16, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

@bradzacherbradzacherAwaiting requested review from bradzacher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@auvred@bradzacher@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp