Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: use nx release#8194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JamesHenry merged 10 commits intomainfromnx-release
Jan 6, 2024
Merged

chore: use nx release#8194

JamesHenry merged 10 commits intomainfromnx-release
Jan 6, 2024

Conversation

JamesHenry
Copy link
Member

For right now, a pinned header at the top of the changelog file is not supported, so I have removed this in every case to avoid confusion once we do the first release after this goes in:

#Change LogAll notable changes to this project will be documented in this file.See[Conventional Commits](https://conventionalcommits.org) for commit guidelines.

I'll add support for a pinned header like that intonx release after this and we can bring it back if we want

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JamesHenry!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedJan 5, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commita38f60e
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/6599331a96369e00085aa2e0
😎 Deploy Previewhttps://deploy-preview-8194--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 96 (🔴 down 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@@ -16,7 +16,6 @@
"executor": "@nx/eslint:lint",
"outputs": ["{options.outputFile}"],
"options": {
"lintFilePatterns": ["packages/ast-spec/**/*.{mts,cts,ts,tsx}"],
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The patterns are no longer required, the source files of the project are all eligible to be linted

JoshuaKGoldberg reacted with rocket emoji
@JamesHenryJamesHenry marked this pull request as ready for reviewJanuary 5, 2024 20:33
@JamesHenry
Copy link
MemberAuthor

@typescript-eslint/triage-team any idea why I am getting these integration-test failures?

@@ -1,8 +1,3 @@
# Change Log
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldbergJan 5, 2024•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

[Question] While we're here, can we change it to# Changelog? I don't know of any other project that uses two words 😄

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ha yeah true

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Awesome to see the Lerna->Nx migration come to a head! 🚀

Requesting changes on moving things torepo-tools and updating the last mention of Lerna from the docs. But I can aquiese if you don't think those should be blocking. 😄

Comment on lines +9 to +10
void (async () => {
try {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

[Suggestion] We can avoid these wrappings by changing the file extension to.mts and adding.mts totsconfig.eslint.json.

Suggested change
void(async()=>{
try{

Copy link
MemberAuthor

@JamesHenryJamesHenryJan 6, 2024•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I did initially and the lint errors went crazy so I punted on that
image

Feel free to adjust in a small follow up if you know what the fix is

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It'stsconfig.eslint.json explicitly including only.ts files in this folder, not.mts.

@JoshuaKGoldbergJoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party labelJan 5, 2024
@JamesHenry
Copy link
MemberAuthor

@JoshuaKGoldberg any thoughts on the failures?

@JoshuaKGoldberg
Copy link
Member

Oh right sorry - it looks like#7890 ->#7891... which is unfortunate because thenx-release branch is up to date. Odd. Maybe a caching issue?

@JamesHenry
Copy link
MemberAuthor

JamesHenry commentedJan 6, 2024•
edited
Loading

@JoshuaKGoldberg@auvred updated per the PR feedback and now everything is passing except for the TSServer tests for eslint-plugin.

I reran it in case it was flakiness, but the failure seems to be consistent. Any ideas please?

https://github.com/typescript-eslint/typescript-eslint/actions/runs/7431162445/job/20221866549?pr=8194

@auvred
Copy link
Member

Oh, this is a known issue, it's not related to this PR. It should be fixed in#8131 ->#8136

@JamesHenry
Copy link
MemberAuthor

Ah cool thanks, pressing ahead with this then while I still have time to focus on it

auvred and JoshuaKGoldberg reacted with hooray emoji

@JamesHenryJamesHenry merged commitd0977ab intomainJan 6, 2024
@JamesHenryJamesHenry deleted the nx-release branchJanuary 6, 2024 11:51
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJan 14, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg requested changes

@auvredauvredauvred requested changes

Assignees
No one assigned
Labels
awaiting responseIssues waiting for a reply from the OP or another party
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@JamesHenry@JoshuaKGoldberg@auvred
[8]ページ先頭
©2009-2025 Movatter.jp