- Fix knip errors in all packages:
- . (root)
  - -Supportworking-directory keyword in GitHub Actions workflows webpro-nl/knip#433
  - -Add support for JavaScript GitHub Actions webpro-nl/knip#432
- ast-spec
- eslint-plugin
- eslint-plugin-internal
- eslint-plugin-tslint
- integration-tests
- parser
- repo-tools
- rule-schema-to-typescript-types
- rule-tester
- scope-manager
- type-utils
- types
- typescript-estree
- utils
- visitor-keys
- website
  - TODO: sync withchore(website): bump Docusaurus to v3 #8209
- website-eslint
- Write a short review explaining non-obvious changes

auvred added2 commits

January 5, 2024 16:39

chore: add knip

d0896c6

chore: sync lockfile

f3bd554

Copy link

Contributor

typescript-eslintbot commentedJan 5, 2024

Thanks for the PR,@auvred!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedJan 5, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`2188ef8`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/66422ee784e82a0008abd70c
😎 Deploy Preview	https://deploy-preview-8192--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 98 (🟢 up 2 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

auvred added3 commits

January 5, 2024 16:42

Merge branch 'main' into chore/add-knip

2d7afbc

chore: bump knip

a9b3dd1

ci: run knip in ci workflow

77d0279

auvred mentioned this pull request

Jan 6, 2024

Supportworking-directory keyword in GitHub Actions workflowswebpro-nl/knip#433

Closed

auvredand others added22 commits

January 6, 2024 08:28

ci: run knip as part of lint job

f074fd7

refactor: replacetestRegex withtestMatch

27163a2

refactor: use satisfies in knip config

919867d

chore: fix path to rule-tester fixtures

3f3abce

chore: add dummypkg as knip workspace

2b53d17

chore: get rid of json-schema

6f32a3e

chore: fix knip issues in packages/website

47d2703

chore: merge main

56a6d1f

chore: merge main 2

8b9e441

chore: sync lockfile

b24377d

chore: add missed merge stuff

5a1255a

chore: install @jest/types in the root workspace

64cb8c4

chore: partially fix issues for website-eslint

91c9909

chore: fix knip issues for packages/website-eslint

1348b52

e7a204c

chore: add ncp resolution to the root package.json

5d37ea8

Merge branch 'main' into chore/add-knip

85df506

chore: wip wip wip

eea474d

chore: fix misspelling + handle few knip issues

de23db8

chore: finally (?)

19e22c5

chore: expand ignoreDependencies regular expressions

5025e67

chore: revert unrelated changes

6dad589

JoshuaKGoldberg reviewed

Apr 23, 2024

View reviewed changes

jest.config.js

		@@ -1,5 +1,9 @@
		'use strict';

		// @ts-check

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

[Praise] Nice, +1 to getting// @ts-check in here.

Revert "!!!"

814c162

This reverts commit36fa481.

JoshuaKGoldberg previously approved these changes

Apr 23, 2024

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

✂️ this is fantastic, nice job@auvred! Love the explanations throughout and all the removed stuff.

Nothing I commented is a blocker IMO. They can all be followup issues IMO.

knip.tsShow resolvedHide resolved

knip.ts Outdated

Comment on lines 63 to 65

		'packages/repo-tools': {
		ignoreDependencies: ['tsconfig.json'],
		},

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yeah this feels like a feature request for Knip: shouldn't it understand thatnpx tsc goes to TypeScript?

...separately,-p defaults totsconfig.json.yarn knip andyarn typecheck pass happily for me when I remove the-p tsconfig.json altogether. Maybe a good reason to remove them?

knip.tsShow resolvedHide resolved

knip.ts OutdatedShow resolvedHide resolved

knip.ts

		'src/mock/lru-cache.js',
		'src/mock/path.js',
		'src/mock/typescript.js',
		'src/mock/util.js',

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You know, as a followup I bet we could switch these over to plain.ts files, and remove the need for therequireResolved that's tripping up Knip... Not blocking at all IMO.

packages/utils/src/eslint-utils/index.ts Outdated

		@@ -1,4 +1,5 @@
		export * from './applyDefault';
		export * from './context';

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Probably yeah. The fact that nobody has reported anything makes me less motivated to - but, yeah, we should.

auvred added3 commits

April 23, 2024 20:27

revert yarn dedupe

5c56b50

sed -i 's| -p tsconfig.json||g'

4d163a2

update todo comment in eslint.config.js

263b528

auvred dismissedJoshuaKGoldberg’sstale review via263b528

April 23, 2024 17:40

Update knip.ts

7e58b47

Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>

auvred mentioned this pull request

Apr 23, 2024

Bug(utils): deprecated helpers for ESLint context are not exported#8975

Closed

4 tasks

auvred added2 commits

April 23, 2024 20:57

oops

c7c1114

Merge branch 'main' into chore/add-knip

c65abae

auvred requested a review fromJoshuaKGoldberg

April 24, 2024 10:37

rubiesonthesky reviewed

Apr 25, 2024

View reviewed changes

packages/repo-tools/package.json

		@@ -13,16 +13,21 @@
		"lint": "npx nx lint",
		"postinstall-script": "npx tsx ./src/postinstall.mts",
		"test": "npx jest --coverage",
		"typecheck": "npx tsc -p tsconfig.json --noEmit"
		"typecheck": "npx tsc --noEmit"

This comment was marked as resolved.

JoshuaKGoldberg previously approved these changes

Apr 26, 2024

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🚀

Copy link

Hey folks, this is great! I didn't check out the details of this PR, but feel free to drag me into this, love to help out a bit here. If there's feature requests or other annoying stuff in/from Knip I'd love to hear about it.

chore: merge main

7bea876

auvred dismissedJoshuaKGoldberg’sstale review via7bea876

April 30, 2024 13:53

Copy link

MemberAuthor

auvred commentedApr 30, 2024•
edited
Loading

~~Integration tests failures are unrelated. See#9029 (comment):~~

~~8127873 /#8640~~
~~This commit changed thecontext.report from{ node, ... } to{ loc, ... } Hence thenodeType is no longer visible in the output as the rule is not reporting against the node.~~

~~I think we can finally merge this PR!~~

UPD: this issue has been resolved onmain

auvredand others added2 commits

May 3, 2024 21:10

Merge branch 'main' into chore/add-knip

81a6914

Merge branch 'main' into chore/add-knip

3506094

auvred requested a review fromJoshuaKGoldberg

May 12, 2024 13:41

Copy link

MemberAuthor

auvred commentedMay 12, 2024

Unfortunately, mergingmain two weeks ago automatically dismissed an existing approval, so I can't merge this PR (the PR authors can't approve their PR). Could someone please re-review and stamp this PR so we can merge it?

Every Monday, after the automatic release, there are a few merge conflicts due to bumped@typescript-eslint/* versions, and it's a bit tedious to resolve them every Monday 😄

Copy link

Contributor

rubiesonthesky commentedMay 13, 2024

@auvred Could you try runningyarn dedupe in this branch and see if all the tests still pass? I think you may have fixed the problem that all the renovate branches have. But I suspect, that it will only manifest itself afteryarn dedupe.