Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

docs: addimport/no-unresolved to perf troubleshooting docs#8190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bradzacher merged 7 commits intotypescript-eslint:mainfromZamiell:patch-1
Jan 28, 2024
Merged

Conversation

Zamiell
Copy link
Contributor

@ZamiellZamiell commentedJan 4, 2024•
edited
Loading

PR Checklist

Overview

I added 2 rules to the page, which are the following:

  • import/no-unresolved
  • import/unambiguous

I believe that these are correctly handled by the TypeScript compiler, correct me if I am wrong.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@Zamiell!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedJan 4, 2024•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit6bd2063
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/65a28e97ebad3600081ec696
😎 Deploy Previewhttps://deploy-preview-8190--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 90 (🔴 down 6 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for sending! I don'tthink any of these changes need to land, but maybe I'm wrong?

Also: please always write an unambiguous title for PRs. That helps both reviewers understand quickly what's going on, and helps the changelog be more informative.

@JoshuaKGoldbergJoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party labelJan 11, 2024
@bradzacherbradzacher changed the titledocs: update Performance.mdxdocs: addimport/no-unresolved to perf troubleshooting docsJan 28, 2024
@bradzacherbradzacher added documentationDocumentation ("docs") that needs adding/updating awaiting responseIssues waiting for a reply from the OP or another party and removed awaiting responseIssues waiting for a reply from the OP or another party labelsJan 28, 2024
@bradzacherbradzacher merged commita9f995a intotypescript-eslint:mainJan 28, 2024
@ZamiellZamiell deleted the patch-1 branchJanuary 28, 2024 02:09
danvk pushed a commit to danvk/typescript-eslint that referenced this pull requestFeb 4, 2024
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsFeb 5, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg requested changes

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
documentationDocumentation ("docs") that needs adding/updating
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@Zamiell@JoshuaKGoldberg@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp