Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
fix(eslint-plugin): [prefer-readonly] support modifiers of unions and intersections#8169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Thanks for the PR,@auvred! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. |
netlifybot commentedJan 2, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
✅ Deploy Preview fortypescript-eslint ready!
To edit notification comments on pull requests, go to yourNetlify site configuration. |
| if (type.isUnion()) { | ||
| // any union of class/instance and something else will prevent access to | ||
| // private members, so we assume that union consists only of classes | ||
| // or class instances, because otherwise tsc will report an error | ||
| return this.getTypeToClassRelation(type.types[0]); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
classTest{privatefoo:number=1privatestaticfoo:numbertest(){constthat1={}astypeofTest| thisthat1.foo=2// ^ 2339: Property 'foo' does not exist on type 'this | typeof Test'constthat2={}as this|{_foo:'bar'}that2.foo=2// ^ 2339: Property 'foo' does not exist on type 'this | { _foo: "bar"; }'constthat3={}astypeofTest|{_foo:'bar'}that3.foo=2// ^ 2339: Property 'foo' does not exist on type 'typeof Test | { _foo: "bar"; }'}}
| @@ -251,6 +251,13 @@ type ParameterOrPropertyDeclaration = | |||
| const OUTSIDE_CONSTRUCTOR = -1; | |||
| const DIRECTLY_INSIDE_CONSTRUCTOR = 0; | |||
| enum TypeToClassRelation { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
[Praise] I found this enum and the logic around it to be quite helpful in understanding the new logic. Very readable. Nice! 👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
💯 !
PR Checklist
Overview