Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(utils): improve error message on typed rule with invalid parser#8146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg commentedDec 27, 2023•
edited
Loading

PR Checklist

Overview

Adds a small regex ingetParserServices to catch common cases of incorrect parsers. It's not comprehensive (../parser.js unfortunately passes) but it does catch the common case ofnode_modules/@babel/*.

Note that this only augments the existing error message. It doesn't add any new error catching / situations wheregetParserServices would throw.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedDec 27, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit649917f
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/6599fbb18071ba0008542e55
😎 Deploy Previewhttps://deploy-preview-8146--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@JoshuaKGoldbergJoshuaKGoldberg changed the titlefeat(utils): throw error on typed rule with invalid parserfeat(utils): improve error message on typed rule with invalid parserDec 28, 2023
@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as ready for reviewDecember 28, 2023 20:33
@bradzacher
Copy link
Member

Note: probably class this as a fix for semver purposes

JoshuaKGoldberg reacted with thumbs up emoji

@JoshuaKGoldbergJoshuaKGoldberg changed the titlefeat(utils): improve error message on typed rule with invalid parserfix(utils): improve error message on typed rule with invalid parserJan 7, 2024
@JoshuaKGoldbergJoshuaKGoldberg merged commit687f73c intotypescript-eslint:mainJan 7, 2024
@JoshuaKGoldbergJoshuaKGoldberg deleted the utils-assert-our-parser branchJanuary 7, 2024 16:11
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJan 15, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

@Josh-CenaJosh-CenaAwaiting requested review from Josh-Cena

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: getParserServices should throw informative error when used with non-typescript-eslint parser
2 participants
@JoshuaKGoldberg@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp