Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: enable eslint-plugin-jsdoc internally#8145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Extends the"plugin:jsdoc/recommended-typescript-error" preset and disables opinionated rules that don't match our pre-existing opinions. Most of those are around requiring docs to always exist.

Doesn't enablejsdoc/informative-docs. That rule is opinionated enough that I'll file a followup issue for it.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedDec 27, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit52c365a
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/659ad027b0e46100086acd91
😎 Deploy Previewhttps://deploy-preview-8145--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as ready for reviewDecember 29, 2023 19:27
bradzacher
bradzacher previously approved these changesJan 7, 2024
@JoshuaKGoldbergJoshuaKGoldberg merged commit1ee3087 intotypescript-eslint:mainJan 7, 2024
@JoshuaKGoldbergJoshuaKGoldberg deleted the eslint-plugin-jsdoc-internally branchJanuary 7, 2024 18:29
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJan 15, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: Bring in eslint-plugin-jsdoc recommended-typescript-error preset
2 participants
@JoshuaKGoldberg@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp