typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.8k

fix(eslint-plugin): [no-unnecessary-type-assertion] detect unnecessary non-null-assertion on a call expression#8143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 7 commits intotypescript-eslint:mainfromlvjiaxuan:feat/no-unnecessary-type-assertion_honor-function-return-type

Jan 12, 2024

Merged

fix(eslint-plugin): [no-unnecessary-type-assertion] detect unnecessary non-null-assertion on a call expression#8143

JoshuaKGoldberg merged 7 commits intotypescript-eslint:mainfromlvjiaxuan:feat/no-unnecessary-type-assertion_honor-function-return-type

Jan 12, 2024

Conversation

Copy link

Contributor

lvjiaxuan commentedDec 27, 2023

PR Checklist

Addresses an existing open issue:fixesBug: [no-unnecessary-type-assertion] does not detect unnecessary non-null-assertion on a call expression #8141
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

lvjiaxuan added4 commits

December 27, 2023 11:20

feat(eslint-plugin): [no-unnecessary-type-assertion] addIdentifier…

566dcd3

… check

feat(eslint-plugin): [no-unnecessary-type-assertion] update fixer for…

7648e55

… `CallExpression`

feat(eslint-plugin): [no-unnecessary-type-assertion] add test case

3fd7304

feat(eslint-plugin): [no-unnecessary-type-assertion] fit more cases

41b7ea5

Copy link

Contributor

typescript-eslintbot commentedDec 27, 2023

Thanks for the PR,@lvjiaxuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedDec 27, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`cc0f363`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/65a0a40c14eef00008eefad0
😎 Deploy Preview	https://deploy-preview-8143--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 96 (no change from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

feat(eslint-plugin): [no-unnecessary-type-assertion] add valid test c…

4fcbc47

…ases

JoshuaKGoldberg changed the title~~feat(eslint-plugin): [no-unnecessary-type-assertion] detect unnecessary non-null-assertion on a call expression~~fix(eslint-plugin): [no-unnecessary-type-assertion] detect unnecessary non-null-assertion on a call expression

Jan 11, 2024

JoshuaKGoldberg requested changes

Jan 11, 2024

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Good stuff! Looks like it works well, so just requesting changes on test coverage and fixing the internal lint complaint.

Btw this is a bugfix rather than a feature so I've edited the PR title. They show up differently in the changelog and have different semver version bump implications.