Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
test(eslint-plugin): assert thatts/tsx code blocks in docs are syntactically valid#8142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Thanks for the PR,@auvred! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. |
netlifybot commentedDec 27, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
✅ Deploy Preview fortypescript-eslint ready!
To edit notification comments on pull requests, go to yourNetlify site configuration. |
| const Comp: FC = () => { | ||
| return <button onClick={() => {}} />; | ||
| }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We can't mix angle bracket assertions and jsx syntax
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, thanks!
I know@Josh-Cena has done a lot with Docusaurus things so leaving open in case they have a chance to review. Will come and merge back in a week otherwise.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Mostly LGTM
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
| }, | ||
| ecmaVersion: 'latest', | ||
| sourceType: 'module', | ||
| range: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Withoutrange: true parser throwsCannot read properties of undefined (reading '0') on valid code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
…yntactically valid (typescript-eslint#8142)* test(eslint-plugin): assert that `ts`/`tsx` code blocks in docs are syntactically valid* revert unintended changes in space-before-blocks.md* chore: shorten examples in consistent-type-assertions.md* refactor: do not parse md file again* docs: more consistent examples for consistent-type-assertions* docs: convert `js` code blocks to `ts`* Update packages/eslint-plugin/tests/docs.test.tsCo-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>* chore: use regex instead of startsWith* chore: fix few codesamples---------Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
PR Checklist
Overview
For now, just trying to parse each code block with
tsandtsxlang