Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(eslint-plugin): deprecate no-extra-semi in favor of ESLint Stylistic equivalent#8123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

https://eslint.style/rules/ts/no-extra-semi is the new space for that rule.

auvred reacted with hooray emoji
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedDec 24, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit6680520
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/6588b49cee31f700082304fa
😎 Deploy Previewhttps://deploy-preview-8123--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 99 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@bradzacher
Copy link
Member

Note that your deprecation banner doesn't show up because you gated it to just layout rules.

JoshuaKGoldberg reacted with thumbs up emoji

bradzacher
bradzacher previously approved these changesDec 24, 2023
@JoshuaKGoldberg
Copy link
MemberAuthor

Note that your deprecation banner doesn't show up because you gated it to just layout rules.

Ah good point. updated#8117 to include the notice if the rule isreplacedBy a@stylistic/.

@JoshuaKGoldbergJoshuaKGoldberg merged commit9368bf3 intotypescript-eslint:mainDec 25, 2023
@JoshuaKGoldbergJoshuaKGoldberg deleted the deprecate-no-extra-semi branchDecember 25, 2023 02:42
auvred pushed a commit to auvred/typescript-eslint that referenced this pull requestDec 29, 2023
…stic equivalent (typescript-eslint#8123)* feat(eslint-plugin): deprecate no-extra-semi in favor of ESLint Stylistic equivalent* generate:configs* Fix configs generation
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJan 2, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Move no-extra-semi into ESLint Stylistic too?

2 participants

@JoshuaKGoldberg@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp