Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore(website): [playground] add twoslash queries#8119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bradzacher merged 7 commits intotypescript-eslint:mainfromauvred:chore/8055
Feb 2, 2024

Conversation

auvred
Copy link
Member

@auvredauvred commentedDec 24, 2023•
edited by JoshuaKGoldberg
Loading

PR Checklist

Overview

The issue is not marked asaccepting prs,so I'm opening it as a draft for now

upd: undrafting ¯\_(ツ)_/¯

I tookthis code frommicrosoft/Typescript-Website and refactored it a bit

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@auvred!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedDec 24, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit90d2e78
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/65bbc5640831500008a6808a
😎 Deploy Previewhttps://deploy-preview-8119--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 96 (🟢 up 6 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@auvredauvred marked this pull request as ready for reviewFebruary 1, 2024 15:19
JoshuaKGoldberg
JoshuaKGoldberg previously approved these changesFeb 1, 2024
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👏 This looks great, thanks for such a clean PR!

No blocking requests from me - just a comment change for a more searchable TS 4.3/4.4 reference, and a couple of small style touchups that we can ignore them if you hate them 😄. WDYT?

@JoshuaKGoldbergJoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelFeb 1, 2024
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
@bradzacherbradzacher merged commit5c253a8 intotypescript-eslint:mainFeb 2, 2024
danvk pushed a commit to danvk/typescript-eslint that referenced this pull requestFeb 4, 2024
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsFeb 10, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergAwaiting requested review from JoshuaKGoldberg

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Website: Add twoslash queries to the playground
3 participants
@auvred@JoshuaKGoldberg@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp