Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

docs(eslint-plugin): add Deprecating Formatting Rules blog post#8117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Summarizes why we're doing this and links to the ESLint blog post + ESLint Stylistic docs as well.

Also includes a fix to the rule replacements: I'd forgottents/ exists as a separate namespace fromdefault/.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedDec 24, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitff4e22f
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/6588b3f31cdab4000969101e
😎 Deploy Previewhttps://deploy-preview-8117--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 95 (🔴 down 3 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link
MemberAuthor

@JoshuaKGoldbergJoshuaKGoldbergDec 24, 2023•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

cc@antfu @typescript-eslint/triage-team - I wish I'd thought to write this post alongside#8072/#8073. Ah well. I've set a reminder to merge this PR in on Monday before our scheduled weekly release. But please do yell at me if anything's off - even if you don't have time till after then. 🙂

Josh-Cena
Josh-Cena previously approved these changesDec 24, 2023
Copy link
Member

@Josh-CenaJosh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Content looks great; not sure if the code change should be a separate PR but no strong feelings

Copy link
Member

@auvredauvred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice post!

I just found a few typos

By the way, maybe this has already been discussed somewhere, but I missed it:
What aboutno-extra-semi rule? It's classified assuggestion rather thanlayout, butit's already a part ofeslint-stylistic

Shouldn't we deprecate it as well? Because otherwise it will be duplicated in bothts-eslint andeslint-stylistic

@Josh-Cena
Copy link
Member

I asked a while ago privately; I think Brad is in favor of removing it too :)

auvred reacted with thumbs up emoji

Co-authored-by: auvred <61150013+auvred@users.noreply.github.com>
Co-authored-by: auvred <61150013+auvred@users.noreply.github.com>
Co-authored-by: auvred <61150013+auvred@users.noreply.github.com>
@JoshuaKGoldberg
Copy link
MemberAuthor

JoshuaKGoldberg commentedDec 24, 2023•
edited
Loading

if the code change should be a separate PR

Heh yeah in theory maybe. But it's all going to ship at the same time. And I think this only impacts documentation anyhow.

@JoshuaKGoldbergJoshuaKGoldberg changed the titlechore(website): add Deprecating Formatting Rules blog postdocs(eslint-plugin): add Deprecating Formatting Rules blog postDec 24, 2023
@JoshuaKGoldbergJoshuaKGoldberg merged commitb3f87fc intotypescript-eslint:mainDec 25, 2023
@JoshuaKGoldbergJoshuaKGoldberg deleted the blog-deprecating-formatting-rules branchDecember 25, 2023 02:43
@antfu
Copy link
Contributor

Thank you! And Merry Christmas to you all!

auvred and JoshuaKGoldberg reacted with hooray emojiJoshuaKGoldberg reacted with heart emoji

auvred added a commit to auvred/typescript-eslint that referenced this pull requestDec 29, 2023
…script-eslint#8117)* chore(website): add Deprecating Formatting Rules blog post* Apply suggestions from code reviewCo-authored-by: auvred <61150013+auvred@users.noreply.github.com>* Update packages/website/blog/2023-12-25-deprecating-formatting-rules.mdCo-authored-by: auvred <61150013+auvred@users.noreply.github.com>* Update packages/website/blog/2023-12-25-deprecating-formatting-rules.mdCo-authored-by: auvred <61150013+auvred@users.noreply.github.com>* Ran format --write* Add no-extra-semi too* Generalize formatting notice to @stylistic/ rules---------Co-authored-by: auvred <61150013+auvred@users.noreply.github.com>
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJan 2, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@auvredauvredauvred requested changes

@Josh-CenaJosh-CenaJosh-Cena left review comments

@bradzacherbradzacherAwaiting requested review from bradzacher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: Add quick blog post about deprecating formatting rules
4 participants
@JoshuaKGoldberg@Josh-Cena@antfu@auvred
[8]ページ先頭
©2009-2025 Movatter.jp