Please tell me if I missed anything, but it turns out we aren't using either of the options ofisNullableType, and I'm not sure if they really matter, so I've removed them. Please let me know if they need to be kept for compatibility (I don't think they are part of the API surface but who knows)?

This change also touches several other rules, but their tests pass anyway, and from a rough look there shouldn't be extra errors.

Copy link

Contributor

typescript-eslintbot commentedDec 18, 2023

Thanks for the PR,@Josh-Cena!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedDec 18, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`99c1828`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/65a05c889affbb0008f44b40
😎 Deploy Preview	https://deploy-preview-8089--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 92 (🔴 down 4 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

fix(eslint-plugin): [no-unnecesary-type-assertion] treat unknown/any …

1f557ae

…as nullable

Josh-Cena force-pushed theunknown-nullable branch fromfa39a81 to1f557aeCompare

December 18, 2023 03:21

Josh-Cena changed the title~~fix(eslint-plugin): [no-unnecesary-type-assertion] treat unknown/any …~~fix(eslint-plugin): [no-unnecesary-type-assertion] treat unknown/any as nullable

Dec 18, 2023

Josh-Cena requested review frombradzacher andJoshuaKGoldberg

December 18, 2023 03:22

JoshuaKGoldberg mentioned this pull request

Dec 18, 2023

Docs: Document @typescript-eslint/type-utils#8093

Closed

2 tasks

Copy link

Member

JoshuaKGoldberg commentedDec 18, 2023

Yeah great point on thetype-utils change... I don't know myself 😄 filed#8093.

StyleShit reviewed

Dec 18, 2023

View reviewed changes

packages/type-utils/src/predicates.ts OutdatedShow resolvedHide resolved

Use isTypeFlagSet

83a7b44

Copy link

Member

bradzacher commentedDec 18, 2023•
edited
Loading

The package is part of our public API. We need to keep backwards compatibility.

Being poorly (or not at all 😅) documented doesn't change that. The only parts of exported packages that we may break at any time are explicitly marked as such in our package.json exports.

Copy link

MemberAuthor

Josh-Cena commentedDec 18, 2023

It is poorly documented and I don't even understand whatisReceiver is supposed to do. Can we keepisReceiver in the type but make it do nothing?

Copy link

Member

JoshuaKGoldberg commentedJan 8, 2024

I think we need to keepisReceiver in the typeand what it's doing now at runtime 😞 but a good followup for v7 would be to remove it.

JoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party label

Jan 8, 2024

Copy link

Member

bradzacher commentedJan 8, 2024

It's been a long long time since#478 so I can't remember the full context for why it was added.

I believe the idea was that in a receiving location (eg the assignment target - the thing that's on the "receiving" end of an assignment) the util would specifically treat any as a "null". Based on the type flags any isn't null IIRC so it needs separate handling.

I think I went in a different direction and so the flag wasn't ever used.