Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(eslint-plugin): deprecate formatting (meta.type: layout) rules#8073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

For every rule whosemeta includestype: 'layout', addsdeprecated: true and removes the rule from theall config.

Note thatchanges to theall config are explicitlynot considered breaking. Perhttps://typescript-eslint.io/linting/configs (added in#5719, back in v5):

With the exception ofall,strict, andstrict-type-checked, all configurations are considered "stable".

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedDec 15, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit0273e89
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/6587a14401f7a8000868326d
😎 Deploy Previewhttps://deploy-preview-8073--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 91 (🔴 down 7 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as ready for reviewDecember 17, 2023 23:59
@bradzacherbradzacher added the enhancementNew feature or request labelDec 23, 2023
bradzacher
bradzacher previously approved these changesDec 23, 2023
Copy link
Member

@bradzacherbradzacher left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

just to confirm - all the deprecated rules are the ones that have been moved toeslint-stylistic, right? Are there any others?

Also accepted but you should mark them all asreplacedBy: ['eslint-stylistic/foo'].

Final note (follow up?) we should add a banner to deprecated rules using this metadata and point them at the replacement docs.

JoshuaKGoldberg reacted with thumbs up emoji
@JoshuaKGoldberg
Copy link
MemberAuthor

Are there any others?

Just did another pass - I did miss one,object-curly-spacing. I'd searched ontype: 'layout' before, but that misses some extension rules that... spread from the base rule.https://typescript-eslint.io/rules/?=formatting is a better query.

👍 on the other two suggestions, good call! Done.

bradzacher
bradzacher previously approved these changesDec 24, 2023
Comment on lines +27 to +32
deprecated: true,
docs: {
description: 'Enforce consistent spacing inside braces',
extendsBaseRule: true,
},
replacedBy: ['@stylistic/object-curly-spacing'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

OCD eye twitch: all the other ones you added on consecutive lines

JoshuaKGoldberg reacted with laugh emoji
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Heh, the other ones are placed before atype:. So they somewhat don't make the sorting less alphabetical. This one doesn't have atype:...

@JoshuaKGoldbergJoshuaKGoldberg merged commit04dea84 intotypescript-eslint:mainDec 24, 2023
@JoshuaKGoldbergJoshuaKGoldberg deleted the deprecate-formatting-rules branchDecember 24, 2023 05:05
auvred pushed a commit to auvred/typescript-eslint that referenced this pull requestDec 29, 2023
…ypescript-eslint#8073)* feat(eslint-plugin): deprecate formatting (meta.type: layout) rules* fix: whoops, forgot to commit all.ts changes* Add replacedBy* Update formatting admonition* Missed object-curly-spacing* areOptionsValid undo* Correct configs and tweak deprecation notice
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsJan 1, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher left review comments

Assignees
No one assigned
Labels
enhancementNew feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

💀 Rule deprecations: formatting rules
2 participants
@JoshuaKGoldberg@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp