Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

docs(eslint-plugin): [require-array-sort-compare] generalize sort method names#8062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JoshuaKGoldberg merged 1 commit intotypescript-eslint:mainfromZamiell:lint-fix
Dec 13, 2023

Conversation

Zamiell
Copy link
Contributor

PR Checklist

Overview

This is a follow-up to my previous PR to make the docs more consistent, since there are two sort methods now.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@Zamiell!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedDec 13, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit09c4702
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/6579bdb1dac52a00082a91b6
😎 Deploy Previewhttps://deploy-preview-8062--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 98 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@JoshuaKGoldbergJoshuaKGoldberg changed the titledocs: streamlinedocs(eslint-plugin): [require-array-sort-compare] generalize sort method namesDec 13, 2023
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM! I'm realizing now I missed a few things with the last round of PR reviews on this rule 😅 thanks for catching them.

Quick notice to please use the repo's general format for PR titles. It helps with auto-generation of changelogs and general repo management (e.g. GH search queries).

Zamiell reacted with thumbs up emoji
@JoshuaKGoldbergJoshuaKGoldberg merged commitf5e712b intotypescript-eslint:mainDec 13, 2023
@ZamiellZamiell deleted the lint-fix branchDecember 13, 2023 17:16
c0sta pushed a commit to c0sta/typescript-eslint that referenced this pull requestDec 18, 2023
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsDec 21, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@Zamiell@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp