Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork2.8k
docs: base Testing Rules documentation#8033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
docs: base Testing Rules documentation#8033
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Thanks for the PR,@c0sta! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint. |
netlifybot commentedDec 7, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
✅ Deploy Preview fortypescript-eslint ready!
To edit notification comments on pull requests, go to yourNetlify site configuration. |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
| - `npm run lint` | ||
| - `yarn lint` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The problem with explicitly listing out "lint" scripts is that there are so many different ways folks can do it, it's hard to express all of them. What aboutpnpm users? What about folks who have different "lint" scripts?
Suggestion: instead of sayinglint and then this list, use a more casual phrase like "your repository's lint script".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Hmm got it, I was trying something like the commands listed on theGlobal Linking but that's right, just pointing out that the user needs to run the repo lint script sounds better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Makes sense. Something already existing in our docs in one way is no guarantee that that's the right way 😄
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for the early peek@c0sta, looking good so far! Left some early stage comments. Definitely open to talking about any+all of them if you have thoughts! :)
…o disable-type-checked (typescript-eslint#8038)fix: add no-unsafe-unary-minus, prefer-destructuring to disable-type-checked
…hod names (typescript-eslint#8062)docs: streamline
Co-authored-by: typescript-eslint[bot] <typescript-eslint[bot]@users.noreply.github.com>
I'm putting this PR onReady for Review, any kinda of suggestion/idea just let me know and I'll be happy to help with it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looking great! Just a few suggestions, but if you hate both of them I'd be absolutely fine switching to approval 😄
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
Oh and:
That's where you'd typically put the |
…t-eslint into docs/how-to-test-changes
At a glance this is looking great! I'll hold off reviewing again until explicitly re-requested. (just posting in case you'd meant to click the re-request button) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Great, thanks! This will be nice and useful for folks getting started with development. 🙌
Uh oh!
There was an error while loading.Please reload this page.
PR Checklist
Overview
Fixes:#4875
Submitting this as a draft to gather some suggestions/ideas and understand if I'm going the right way here.
I did all these steps insideLocal Linking and I was able to see my console.log running at my downstream repository, from what I've tried these steps are very straightforward so I'm not sure if there any more steps or more examples that I could point out here.
Tonight I aim to review and be more descriptive on the "run your
lintscript" step because it seems kinda "empty".