Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

docs: blog post on parserOptions.projectService#8031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
JoshuaKGoldberg wants to merge28 commits intotypescript-eslint:main
base:main
Choose a base branch
Loading
fromJoshuaKGoldberg:blog-parser-options-project-service

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg commentedDec 6, 2023•
edited
Loading

PR Checklist

Overview

Adds a blog post that describes usingparserOptions.projectService (what we previously calledparserOptions.EXPERIMENTAL_useProjectService). The flow is roughly:

  1. Introduction: the old situation & an overview of the blog post
  2. Configuration: how to switch over & replace traditional config kludge
  3. Predictability: benefits of the new API & not havingtsconfig.eslint.jsons
  4. Scalability: project references support! 🙌
  5. Performance: noting that it's theoretically faster, but not always -- and that that's being treated as a bug
  6. Next steps: feedback, the standalone package, and hope for typescript-go

This was previously blocked on:

This previously had a lot more content on single-run mode and performance comparisons. Both are removed for a more streamlined blog post.

💖

huynhducduy and johannes-lindgren reacted with thumbs up emoji
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedDec 6, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commitf08e16f
🔍 Latest deploy loghttps://app.netlify.com/projects/typescript-eslint/deploys/682df891fcb7880008902610
😎 Deploy Previewhttps://deploy-preview-8031--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 99 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify project configuration.

Copy link
Member

@Josh-CenaJosh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Great to see exciting features

Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
@nx-cloudNx Cloud
Copy link

nx-cloudbot commentedMay 11, 2024•
edited
Loading

View yourCI Pipeline Execution ↗ for commitf08e16f.

CommandStatusDurationResult
nx run-many -t typecheck✅ Succeeded2m 6sView ↗
nx run-many -t lint✅ Succeeded8sView ↗
nx run integration-tests:test✅ Succeeded<1sView ↗
nx run types:build✅ Succeeded<1sView ↗
nx test typescript-estree --coverage=false✅ Succeeded<1sView ↗
nx test eslint-plugin-internal --coverage=false✅ Succeeded<1sView ↗
nx test eslint-plugin --coverage=false✅ Succeeded<1sView ↗
nx typecheck ast-spec✅ Succeeded<1sView ↗
Additional runs (29)✅ Succeeded...View ↗

☁️Nx Cloud last updated this comment at2025-05-21 16:12:45 UTC

@JoshuaKGoldberg
Copy link
MemberAuthor

Status update: this is roughly ready for reviewexceptparserOptions.projectService no longer outperformsparserOptions.project. That's being investigated in#9571. If we don't get enough fixes on our end & TypeScript's by the time v8 is meant to go stable, we'll have to rephrase the ⚡ Performance section.

@JoshuaKGoldbergJoshuaKGoldberg added the blocked by another PRPRs which are ready to go but waiting on another PR labelJul 18, 2024
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Changes here are unintentional merge artifacts. Will revert.

@JoshuaKGoldbergJoshuaKGoldberg removed blocked by another PRPRs which are ready to go but waiting on another PR blocked by external APIBlocked by a tool we depend on exposing an API, such as TypeScript's Type Relationship API blocked by another issueIssues which are not ready because another issue needs to be resolved first labelsAug 14, 2024
- ESLint's `--fix` mode breaks type information after the first run ([#9577](https://github.com/typescript-eslint/typescript-eslint/pull/9577))
- Extra file extensions, such as those used by `.svelte` and `.vue`, are not supported ([#9504](https://github.com/typescript-eslint/typescript-eslint/issues/9504))

typescript-eslint's single-run inference enables uses common heuristics such as checking for `'--fix'` in `process.argv`, the presence of `process.env.CI`, and the presence of `parserOptions.extraFileExtensions`.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

nit: typo, I made a guess at the intended wording:

Suggested change
typescript-eslint's single-run inferenceenablesuses common heuristics such as checking for`'--fix'` in`process.argv`, the presence of`process.env.CI`, and the presence of`parserOptions.extraFileExtensions`.
typescript-eslint's single-run inference uses common heuristics such as checking for`'--fix'` in`process.argv`, the presence of`process.env.CI`, and the presence of`parserOptions.extraFileExtensions`.

@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as ready for reviewMay 21, 2025 16:00

As of typescript-eslint@8.33.0, we've also extracted most of the Project Service code into a standalone [`@typescript-eslint/project-service`](/packages/project-service) package.
It has no dependencies on ESLint and is designed to be usable for any linter to enable TypeScript's Project Service API for typed linting.
See [Packages > Project Service](/packages/project-service) for more details.
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Note that#10383 (comment) proposes a pretty big shake-up in other packages. I don't think it impacts this though. Just an FYI :)

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@AdamVigAdamVigAdamVig left review comments

@Jack-WorksJack-WorksJack-Works left review comments

@AhmedBasetAhmedBasetAhmedBaset left review comments

@Josh-CenaJosh-CenaAwaiting requested review from Josh-Cena

@bradzacherbradzacherAwaiting requested review from bradzacher

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: Add blog post & revamped docs for parserOptions.projectService
7 participants
@JoshuaKGoldberg@Zamiell@AdamVig@Jack-Works@bradzacher@Josh-Cena@AhmedBaset
[8]ページ先頭
©2009-2025 Movatter.jp