Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

docs(eslint-plugin): [no-throw-literal] fix typo in example#8006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

auvred
Copy link
Member

PR Checklist

Overview

I just accidentally opened example in the playground and noticed that there is an extra semicolon

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@auvred!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedNov 29, 2023•
edited
Loading

❌ Deploy Preview fortypescript-eslint failed.

NameLink
🔨 Latest commitb3e6342
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/656c6d44582ca200082bbd7f

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ha, nice catch - thanks!

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ah the CI is failing - could you format the file please?yarn format --write should do the trick. Thanks!

(I can soon if you don't have time - I just don't want to take authorship away 🙂)

@JoshuaKGoldbergJoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party labelNov 29, 2023
@auvred
Copy link
MemberAuthor

Fixed it, I also removed eslint comments as they are not needed here (?)

@github-actionsgithub-actionsbot removed the awaiting responseIssues waiting for a reply from the OP or another party labelDec 3, 2023
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

💯 thanks!

@JoshuaKGoldbergJoshuaKGoldberg merged commit314f034 intotypescript-eslint:mainDec 5, 2023
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsDec 13, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@auvred@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp