Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(eslint-plugin): [require-await] allow yielding Promise in async generators#8003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JoshuaKGoldberg merged 2 commits intotypescript-eslint:mainfromauvred:feat/7995
Dec 5, 2023

Conversation

auvred
Copy link
Member

PR Checklist

Overview

I had to slightly refactormarkAsHasDelegateGen:

  1. Early return fromif (node.argument.type === AST_NODE_TYPES.Literal) sincescopeInfo.isAsyncYield ||= false; is meaningless
  2. Now function accepts both nodes withdelegate=true anddelegate=false

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@auvred!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedNov 28, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit3a1c869
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/65662b287844cb000842c75c
😎 Deploy Previewhttps://deploy-preview-8003--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 90 (🟢 up 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

💯 this is perfect, thanks as usual!

@JoshuaKGoldbergJoshuaKGoldberg merged commit4c3e704 intotypescript-eslint:mainDec 5, 2023
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsDec 13, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: [require-await] add an option to ignore async generators or support yield Promise
2 participants
@auvred@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp