docs: updated globalSetup to setupFiles#8000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 2 commits intotypescript-eslint:mainfromc0sta:docs/update-vitest-setup

Nov 28, 2023

Merged

docs: updated globalSetup to setupFiles#8000

JoshuaKGoldberg merged 2 commits intotypescript-eslint:mainfromc0sta:docs/update-vitest-setup

Nov 28, 2023

Conversation

Copy link

Contributor

c0sta commentedNov 28, 2023•
edited
Loading

PR Checklist

Addresses an existing open issue:fixesDocs: Vitest guide should refer to setupFiles, not globalSetup #7830
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

I've updated the docs on Vitest section of Rule Tester package to usesetupFiles instead ofglobalSetup, according to the issue description.

Image

docs(RuleTester): updated globalSetup to setupFiles

af8a9c9

Copy link

Contributor

typescript-eslintbot commentedNov 28, 2023

Thanks for the PR,@c0sta!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedNov 28, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`980de3e`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6565ca74398bbb00088810b7
😎 Deploy Preview	https://deploy-preview-8000--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 90 (🟢 up 2 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports