In hindsight#7997 was sadly a breaking change.
There's a number of usecases that do rely on accessing JSDoc on the TS AST (egeslint-plugin-deprecation).

This PR amends this change so that:

we accept the setting via parser options so it's user-configurable.
we default JSDoc parsing toall (which was the pre-5.3 behaviour) for type-aware linting.
we default JSDoc parsing tonone for non-type-aware-linting.
- Setting this tonone by default for this case should provide all non-type-aware-linting users with a free perf boost.
- This istechnically a breaking change - but the scope should be zero.
- The only usecase this impacts is "accessing JSDoc from the TS AST when not using type-aware linting".
- This usecase is possible - but I don't think it's something anyone would ever do as this would only give you JSDoc for the current file. Most single-file rules assume there's no TS AST.
- If we do encounter a breakage we can revert this back toall - but I don't think we'll see it.

In a future we can consider switching the type-aware default to'type-info' and force users to pass the config if and only if they use a rule that requires'all'.

FYI@jakebailey /@fisker

fix: default to parse all JSDoc and provide options to configure it

70eb918

bradzacher added the bugSomething isn't working label

Nov 28, 2023

bradzacher requested a review fromJoshuaKGoldberg

November 28, 2023 00:31

Copy link

Contributor

typescript-eslintbot commentedNov 28, 2023

Thanks for the PR,@bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedNov 28, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`70ecbb6`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/65653b753f2a6c0008ff31c0
😎 Deploy Preview	https://deploy-preview-7999--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 99 (🟢 up 1 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

bradzacher requested a review fromjakebailey

November 28, 2023 00:31

jakebailey reviewed

Nov 28, 2023

View reviewed changes

packages/typescript-estree/src/parseSettings/createParseSettings.ts OutdatedShow resolvedHide resolved

jakebailey reviewed

Nov 28, 2023

View reviewed changes

packages/typescript-estree/src/create-program/createProjectService.ts

		@@ -9,7 +9,9 @@ const createStubFileWatcher = (): ts.FileWatcher => ({

		export type TypeScriptProjectService = ts.server.ProjectService;

		export function createProjectService(): TypeScriptProjectService {
		export function createProjectService(
		jsDocParsingMode?: ts.JSDocParsingMode,