fix(typescript-estree): ensure backwards compat with pre-5.3 import attributes#7967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

bradzacher merged 1 commit intomainfrom7960-import-attribute-backwards-compat

Nov 21, 2023

Merged

fix(typescript-estree): ensure backwards compat with pre-5.3 import attributes#7967

bradzacher merged 1 commit intomainfrom7960-import-attribute-backwards-compat

Nov 21, 2023

Conversation

Copy link

Member

bradzacher commentedNov 20, 2023

PR Checklist

Addresses an existing open issue:fixesBug: Unexpected nodeTSAssertEntry #7960
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

We don't have old TS version regression tests so this is a bit of a "trust me bro".
Manual test steps:

checkout branch
yarn && yarn build
copy folderpackages/typescript-estree/dist
open a new folder
yarn add @typescript-eslint/typescript-estree
runnode and use the repl from the issue (require('@typescript-eslint/typescript-estree').parse('import json from "./foo.json" assert { type: "json", type: "bar" };').body[0].attributes) --> observe the broken AST is printed.
paste the copied dist folder tonode_modules/@typescript-eslint/typescript-estree/
runnode and use the repl from the issue --> observe the correct AST is printed.

fix(typescript-estree): ensure backwards compat with pre-5.3 import a…

a7d2b8e

…ttributes

bradzacher added the bugSomething isn't working label

Nov 20, 2023

Copy link

Contributor

typescript-eslintbot commentedNov 20, 2023

Thanks for the PR,@bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedNov 20, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`a7d2b8e`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/655bef87a3423b000850bfe1
😎 Deploy Preview	https://deploy-preview-7967--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 98 (🟢 up 7 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports