typescript-eslint/typescript-eslintPublic

NotificationsYou must be signed in to change notification settings
Fork2.8k
Star15.8k

feat(eslint-plugin): [no-useless-template-literals] add new rule#7957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 23 commits intotypescript-eslint:mainfromStyleShit:feat/no-useless-template-literals

Dec 12, 2023

Merged

feat(eslint-plugin): [no-useless-template-literals] add new rule#7957

JoshuaKGoldberg merged 23 commits intotypescript-eslint:mainfromStyleShit:feat/no-useless-template-literals

Dec 12, 2023

Conversation

Copy link

Contributor

StyleShit commentedNov 19, 2023

Closes#2846

feat(eslint-plugin): [no-useless-template-literals] add new rule

d56e6f2

Closestypescript-eslint#2846

Copy link

Contributor

typescript-eslintbot commentedNov 19, 2023

Thanks for the PR,@StyleShit!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedNov 19, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`408e5c7`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/657890ae3d0840000917c4a3
😎 Deploy Preview	https://deploy-preview-7957--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 90 (🔴 down 7 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

StyleShit commented

Nov 19, 2023

View reviewed changes

packages/eslint-plugin/src/rules/no-useless-template-literals.ts Outdated

Comment on lines 68 to 71

		context.report({
		node,
		messageId: 'noUselessTemplateLiteral',
		});

Copy link

ContributorAuthor

StyleShitNov 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

should probably add a fixer in another PR
will raise a new issue after this one is merged

fix tests

5affb9e

StyleShit commented

Nov 19, 2023

View reviewed changes

packages/eslint-plugin/src/rules/index.ts OutdatedShow resolvedHide resolved

JoshuaKGoldberg requested changes

Nov 20, 2023

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🚀 a great start! Requested some changes that I suspect might require some code changes. Can take a deeper look once they're resolved. Many thanks for sending this in!

packages/eslint-plugin/tests/rules/no-useless-template-literals.test.ts OutdatedShow resolvedHide resolved

packages/eslint-plugin/tests/rules/no-useless-template-literals.test.tsShow resolvedHide resolved

packages/eslint-plugin/tests/rules/no-useless-template-literals.test.ts OutdatedShow resolvedHide resolved

packages/eslint-plugin/src/rules/no-useless-template-literals.ts OutdatedShow resolvedHide resolved

packages/eslint-plugin/docs/rules/no-useless-template-literals.mdShow resolvedHide resolved

JoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party label

Nov 20, 2023

StyleShit added3 commits

November 20, 2023 19:10

thank you josh

77593ac

hopefully fix tests?

d924265

Merge remote-tracking branch 'typescript-eslint/main' into feat/no-us…

20d9b37

…eless-template-literals

StyleShit requested a review fromJoshuaKGoldberg

November 20, 2023 17:16

github-actionsbot removed the awaiting responseIssues waiting for a reply from the OP or another party label

Nov 20, 2023

StyleShit added3 commits

November 20, 2023 19:49

support template literals with new lines

5e89515

support also quotes

ba23199

fix all files (damn, we need an auto fixer...)

dd17ad1

Copy link

ContributorAuthor

StyleShit commentedNov 20, 2023

IDK why prettier is failing, seems to be fine locally

Merge branch 'main' into feat/no-useless-template-literals

479c10a

StyleShit commented

Dec 3, 2023

View reviewed changes

packages/eslint-plugin/src/rules/no-useless-template-literals.ts OutdatedShow resolvedHide resolved

JoshuaKGoldberg requested changes

Dec 5, 2023

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Getting closer, fantastic! 🥳

Mostly requesting changes on making the rule not flag stylistic points. On deeper thought I think there's some more testing to be done too.

Thanks!

packages/eslint-plugin/src/rules/no-useless-template-literals.ts OutdatedShow resolvedHide resolved

packages/eslint-plugin/src/rules/member-ordering.ts OutdatedShow resolvedHide resolved

packages/eslint-plugin/src/rules/no-useless-template-literals.ts OutdatedShow resolvedHide resolved

packages/eslint-plugin/tests/rules/no-useless-template-literals.test.tsShow resolvedHide resolved

JoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party label

Dec 5, 2023

JoshuaKGoldberg reviewed

Dec 5, 2023

View reviewed changes

packages/eslint-plugin/docs/rules/no-useless-template-literals.md OutdatedShow resolvedHide resolved

park-jemin reviewed

Dec 6, 2023

View reviewed changes

packages/eslint-plugin/tests/rules/no-useless-template-literals.test.ts OutdatedShow resolvedHide resolved

StyleShit added7 commits

December 10, 2023 09:56

wip

fbdd6f3

Merge remote-tracking branch 'typescript-eslint/main' into feat/no-us…

0a8e985

…eless-template-literals

report on specific node

7f0cc39

fix docs

d22b0f8

fix lint

775594d

wip

4da820d

fix lint

1a545b8

github-actionsbot removed the awaiting responseIssues waiting for a reply from the OP or another party label

Dec 10, 2023

Copy link

ContributorAuthor

StyleShit commentedDec 10, 2023

no idea why the build is failing

Copy link

Member

JoshuaKGoldberg commentedDec 11, 2023•
edited
Loading

Btw@StyleShit I appreciate you answering every thread 🙂 but if it's easier for you, you can just mark them as resolved. That's the flow we usually use when it's a straightforward "yes"/"done".

Copy link

Member

JoshuaKGoldberg commentedDec 11, 2023

no idea why the build is failing

Yeah 🙁 not related to this PR. Should be fixed by#8048. I'll update the branch.

Merge branch 'main' into feat/no-useless-template-literals

0068bd1

Copy link

ContributorAuthor

StyleShit commentedDec 11, 2023•
edited
Loading

Btw@StyleShit I appreciate you answering every thread 🙂 if it's easier for you, you can just mark them as resolved.

@JoshuaKGoldberg
Hehe that's the force of a habit...
At Elementor, we usually answer every thread to make sure we didn't miss anything, and let the reviewer resolve the thread.
It helps the reviewers keeping track of the discussions and put themselves back into context on a re-review.

We usually either answer with "done" or start a discussion about the review comment.

Copy link

Member

JoshuaKGoldberg commentedDec 11, 2023•
edited
Loading

I, yet again, am resentful that GitHub's PR process doesn't give a way to distinguish between"one of us in this conversation thinks it's resolved" and"both of us in this conversation think it's resolved"... 🙃

JoshuaKGoldberg requested changes

Dec 11, 2023

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ok this is looking great! Thanks for keeping working on it. 🙌

Apologies for the late-breaking request: I think the only blocker (other than reverting unrelated changes) is also reporting on unnecessary non-string literals such asbigint andnumber. Or at least, resolving the conversation around them is.

packages/eslint-plugin/tests/docs.test.ts OutdatedShow resolvedHide resolved

packages/eslint-plugin/tests/rules/no-useless-template-literals.test.ts OutdatedShow resolvedHide resolved

JoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party label

Dec 11, 2023

StyleShit added5 commits

December 12, 2023 08:49

revert unrelated changes

ba1ddbd

Merge remote-tracking branch 'typescript-eslint/main' into feat/no-us…

e24e0f2

…eless-template-literals

Merge branch 'feat/no-useless-template-literals' ofhttps://github.co…

4c0eda3

…m/StyleShit/typescript-eslint into feat/no-useless-template-literals

more reverts

4b2f9e1

wip

a971081

StyleShit requested a review fromJoshuaKGoldberg

December 12, 2023 07:28

github-actionsbot removed the awaiting responseIssues waiting for a reply from the OP or another party label

Dec 12, 2023

JoshuaKGoldberg requested changes

Dec 12, 2023

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

(just#7957 (comment) left)

JoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party label

Dec 12, 2023

wip

408e5c7

StyleShit requested a review fromJoshuaKGoldberg

December 12, 2023 16:56

github-actionsbot removed the awaiting responseIssues waiting for a reply from the OP or another party label

Dec 12, 2023

JoshuaKGoldberg approved these changes

Dec 12, 2023

View reviewed changes

Copy link

Member

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🎆 this is great, thanks for all your work on it!

Looking forward to getting this intorecommended for v7 😄

JoshuaKGoldberg merged commitff75785 intotypescript-eslint:main

Dec 12, 2023

StyleShit mentioned this pull request

Dec 12, 2023

Enhancement: [no-useless-template-literals] Add fixing suggestions#8056

Closed

4 tasks

Copy link

ContributorAuthor

StyleShit commentedDec 12, 2023

filed a new issue as promised:
#8056

auvred mentioned this pull request

Dec 13, 2023

chore: resolve internal lint issues with new no-useless-template-literals rule#8060

Merged

3 tasks

Copy link

karlhorky commentedDec 18, 2023

Just tested this in@typescript-eslint/eslint-plugin@6.15.0 and it works well, thanks@StyleShit and@JoshuaKGoldberg and everyone else involved! 🙌

Copy link

Contributor

Zamiell commentedDec 19, 2023•
edited
Loading

thanks Style, this is a very nice rule!
it caught bugs in my codebase : )

Vylpes pushed a commit to Vylpes/Droplet that referenced this pull request

Dec 25, 2023

Update dependency @typescript-eslint/eslint-plugin to v6.15.0 (#242)

b194083

This PR contains the following updates:| Package | Type | Update | Change ||---|---|---|---|| [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`6.10.0` -> `6.15.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/6.10.0/6.15.0) |---### Release Notes<details><summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/eslint-plugin)</summary>### [`v6.15.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#6150-2023-12-18)[Compare Source](typescript-eslint/typescript-eslint@v6.14.0...v6.15.0)##### Features-   **eslint-plugin:** \[no-useless-template-literals] add new rule ([#&#8203;7957](typescript-eslint/typescript-eslint#7957)) ([ff75785](typescript-eslint/typescript-eslint@ff75785)), closes [#&#8203;2846](typescript-eslint/typescript-eslint#2846)-   require-array-sort-compare + toSorted ([#&#8203;8052](typescript-eslint/typescript-eslint#8052)) ([c9661c8](typescript-eslint/typescript-eslint@c9661c8))You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.### [`v6.14.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#6140-2023-12-11)[Compare Source](typescript-eslint/typescript-eslint@v6.13.2...v6.14.0)##### Bug Fixes-   **eslint-plugin:** add no-unsafe-unary-minus, prefer-destructuring to disable-type-checked ([#&#8203;8038](typescript-eslint/typescript-eslint#8038)) ([431cd15](typescript-eslint/typescript-eslint@431cd15))-   **eslint-plugin:** correct message for `no-unsafe-unary-minus` ([#&#8203;7998](typescript-eslint/typescript-eslint#7998)) ([705370a](typescript-eslint/typescript-eslint@705370a))##### Features-   **eslint-plugin:** \[explicit-function-return-type] add support for typed class property definitions ([#&#8203;8027](typescript-eslint/typescript-eslint#8027)) ([bff47d7](typescript-eslint/typescript-eslint@bff47d7))-   **eslint-plugin:** \[require-await] allow yielding Promise in async generators ([#&#8203;8003](typescript-eslint/typescript-eslint#8003)) ([4c3e704](typescript-eslint/typescript-eslint@4c3e704))You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.#### [6.13.2](typescript-eslint/typescript-eslint@v6.13.1...v6.13.2) (2023-12-04)**Note:** Version bump only for package [@&#8203;typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/eslint-plugin)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.#### [6.13.1](typescript-eslint/typescript-eslint@v6.13.0...v6.13.1) (2023-11-28)**Note:** Version bump only for package [@&#8203;typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/eslint-plugin)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.### [`v6.13.2`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#6132-2023-12-04)[Compare Source](typescript-eslint/typescript-eslint@v6.13.1...v6.13.2)**Note:** Version bump only for package [@&#8203;typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/eslint-plugin)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.### [`v6.13.1`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#6131-2023-11-28)[Compare Source](typescript-eslint/typescript-eslint@v6.13.0...v6.13.1)**Note:** Version bump only for package [@&#8203;typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/eslint-plugin)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.### [`v6.13.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#6130-2023-11-27)[Compare Source](typescript-eslint/typescript-eslint@v6.12.0...v6.13.0)**Note:** Version bump only for package [@&#8203;typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/eslint-plugin)You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.### [`v6.12.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#6120-2023-11-20)[Compare Source](typescript-eslint/typescript-eslint@v6.11.0...v6.12.0)##### Bug Fixes-   **eslint-plugin:** \[class-methods-use-this] detect a problematic case for private/protected members if `ignoreClassesThatImplementAnInterface` is set ([#&#8203;7705](typescript-eslint/typescript-eslint#7705)) ([155aa1f](typescript-eslint/typescript-eslint@155aa1f))-   **eslint-plugin:** \[no-unnecessary-condition] fix false positive with computed member access and branded key type ([#&#8203;7706](typescript-eslint/typescript-eslint#7706)) ([f151b26](typescript-eslint/typescript-eslint@f151b26))-   **eslint-plugin:** \[switch-exhaustiveness-check] enum members with new line or single quotes are not being fixed correctly ([#&#8203;7806](typescript-eslint/typescript-eslint#7806)) ([a034d0a](typescript-eslint/typescript-eslint@a034d0a)), closes [#&#8203;7768](typescript-eslint/typescript-eslint#7768)##### Features-   \[member-ordering] add accessor support for member-ordering ([#&#8203;7927](typescript-eslint/typescript-eslint#7927)) ([3c8312d](typescript-eslint/typescript-eslint@3c8312d))-   **eslint-plugin:** \[switch-exhaustiveness-check] add requireDefaultForNonUnion option ([#&#8203;7880](typescript-eslint/typescript-eslint#7880)) ([4cfcd45](typescript-eslint/typescript-eslint@4cfcd45))You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.### [`v6.11.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#6110-2023-11-13)[Compare Source](typescript-eslint/typescript-eslint@v6.10.0...v6.11.0)##### Bug Fixes-   **eslint-plugin:** \[explicit-function-return-type] support JSX attributes in `allowTypedFunctionExpressions` ([#&#8203;7553](typescript-eslint/typescript-eslint#7553)) ([be2777c](typescript-eslint/typescript-eslint@be2777c))-   **eslint-plugin:** \[no-unnecessary-qualifier] handle nested namespace id ([#&#8203;7883](typescript-eslint/typescript-eslint#7883)) ([a668f5b](typescript-eslint/typescript-eslint@a668f5b))##### Features-   add `no-unsafe-unary-minus` rule ([#&#8203;7390](typescript-eslint/typescript-eslint#7390)) ([c4709c2](typescript-eslint/typescript-eslint@c4709c2))-   add types for flat config files ([#&#8203;7273](typescript-eslint/typescript-eslint#7273)) ([66cd0c0](typescript-eslint/typescript-eslint@66cd0c0))-   allow typescript@5.3.0-RC as devDependency ([#&#8203;7821](typescript-eslint/typescript-eslint#7821)) ([b6c40b4](typescript-eslint/typescript-eslint@b6c40b4))-   **eslint-plugin:** no-unsafe-enum-comparison handles switch cases ([#&#8203;7898](typescript-eslint/typescript-eslint#7898)) ([72cb9e4](typescript-eslint/typescript-eslint@72cb9e4))-   **utils:** add ESLint `CodePath` selector types ([#&#8203;7551](typescript-eslint/typescript-eslint#7551)) ([99a026f](typescript-eslint/typescript-eslint@99a026f))You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.</details>---### Configuration📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.🔕 **Ignore**: Close this PR and you won't be reminded about this update again.--- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box---This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4wLjAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4wLjAiLCJ0YXJnZXRCcmFuY2giOiJkZXZlbG9wIn0=-->Reviewed-on:https://gitea.vylpes.xyz/RabbitLabs/Droplet/pulls/242Reviewed-by: Vylpes <ethan@vylpes.com>Co-authored-by: Renovate Bot <renovate@vylpes.com>Co-committed-by: Renovate Bot <renovate@vylpes.com>

github-actionsbot locked asresolvedand limited conversation to collaborators

Dec 27, 2023

Labels

None yet

5 participants

Movatterモバイル変換

Uh oh!

feat(eslint-plugin): [no-useless-template-literals] add new rule#7957

feat(eslint-plugin): [no-useless-template-literals] add new rule#7957

Uh oh!

Conversation

StyleShit commentedNov 19, 2023

Uh oh!

typescript-eslintbot commentedNov 19, 2023

Uh oh!

netlifybot commentedNov 19, 2023• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

✅ Deploy Preview fortypescript-eslint ready!

Uh oh!

StyleShitNov 19, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

StyleShit commentedNov 20, 2023

Uh oh!

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

StyleShit commentedDec 10, 2023

Uh oh!

JoshuaKGoldberg commentedDec 11, 2023• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

JoshuaKGoldberg commentedDec 11, 2023

Uh oh!

StyleShit commentedDec 11, 2023• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

JoshuaKGoldberg commentedDec 11, 2023• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

StyleShit commentedDec 12, 2023

Uh oh!

karlhorky commentedDec 18, 2023

Uh oh!

Zamiell commentedDec 19, 2023• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

Uh oh!

netlifybot commentedNov 19, 2023•
edited
Loading

JoshuaKGoldberg commentedDec 11, 2023•
edited
Loading

StyleShit commentedDec 11, 2023•
edited
Loading

JoshuaKGoldberg commentedDec 11, 2023•
edited
Loading

Zamiell commentedDec 19, 2023•
edited
Loading