Jan 28, 2024 · Oct 24, 2023 · Nov 28, 2023 · Nov 29, 2023 · Nov 29, 2023 · Jan 7, 2024
diff --git a/.eslintrc.js b/.eslintrc.js
    // make sure we're not leveraging any deprecated APIs
    'deprecation/deprecation': 'error',

    // TODO(#7338): Investigate enabling these soon ✨
    '@typescript-eslint/prefer-nullish-coalescing': 'off',

    // TODO(#7130): Investigate changing these in or removing these from presets
    '@typescript-eslint/no-confusing-void-expression': 'off',
    '@typescript-eslint/prefer-string-starts-ends-with': 'off',
      'error',
      { varsIgnorePattern: '^_', argsIgnorePattern: '^_' },
    ],
    '@typescript-eslint/prefer-nullish-coalescing': [
      'error',
      {
        ignoreConditionalTests: true,
        ignorePrimitives: true,
      },
    ],

    //
    // Internal repo rules
diff --git a/packages/eslint-plugin/src/rules/padding-line-between-statements.ts b/packages/eslint-plugin/src/rules/padding-line-between-statements.ts
            }
            return true;
          },
        })|| nextNode;
        })?? nextNode;
      const insertText = isTokenOnSameLine(prevToken, nextToken)
        ? '\n\n'
        : '\n';
diff --git a/packages/eslint-plugin/src/rules/unified-signatures.ts b/packages/eslint-plugin/src/rules/unified-signatures.ts
        }

        return typeContainsTypeParameter(
          (type as Partial<TSESTree.TSTypeAnnotation>).typeAnnotation||
          (type as Partial<TSESTree.TSTypeAnnotation>).typeAnnotation??
            (type as TSESTree.TSArrayType).elementType,
        );
      }
      key ??= getOverloadKey(signature);
      if (
        currentScope &&
        (containingNode|| signature).parent === currentScope.parent
        (containingNode?? signature).parent === currentScope.parent
      ) {
        const overloads = currentScope.overloads.get(key);
        if (overloads !== undefined) {
diff --git a/packages/rule-tester/src/utils/getRuleOptionsSchema.ts b/packages/rule-tester/src/utils/getRuleOptionsSchema.ts
  }

  // Given a full schema, leave it alone
  return schema|| null;
  return schema?? null;
 }
Original file line number	Diff line number	Diff line change
Expand Up		@@ -51,9 +51,6 @@ module.exports = {
		// make sure we're not leveraging any deprecated APIs
		'deprecation/deprecation': 'error',

		// TODO(#7338): Investigate enabling these soon ✨
		'@typescript-eslint/prefer-nullish-coalescing': 'off',

		// TODO(#7130): Investigate changing these in or removing these from presets
		'@typescript-eslint/no-confusing-void-expression': 'off',
		'@typescript-eslint/prefer-string-starts-ends-with': 'off',
Expand DownExpand Up		@@ -109,6 +106,13 @@ module.exports = {
		'error',
		{ varsIgnorePattern: '^_', argsIgnorePattern: '^_' },
		],
		'@typescript-eslint/prefer-nullish-coalescing': [
		'error',
		{
		ignoreConditionalTests: true,
		ignorePrimitives: true,
		},
		],

		//
		// Internal repo rules
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -476,7 +476,7 @@ function verifyForAlways(
		}
		return true;
		},
		})\|\| nextNode;
		})?? nextNode;
		const insertText = isTokenOnSameLine(prevToken, nextToken)
		? '\n\n'
		: '\n';
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -369,7 +369,7 @@ export default createRule<Options, MessageIds>({
		}

		return typeContainsTypeParameter(
		(type as Partial<TSESTree.TSTypeAnnotation>).typeAnnotation\|\|
		(type as Partial<TSESTree.TSTypeAnnotation>).typeAnnotation??
		(type as TSESTree.TSArrayType).elementType,
		);
		}
Expand DownExpand Up		@@ -523,7 +523,7 @@ export default createRule<Options, MessageIds>({
		key ??= getOverloadKey(signature);
		if (
		currentScope &&
		(containingNode\|\| signature).parent === currentScope.parent
		(containingNode?? signature).parent === currentScope.parent
		) {
		const overloads = currentScope.overloads.get(key);
		if (overloads !== undefined) {
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -33,5 +33,5 @@ export function getRuleOptionsSchema(
		}

		// Given a full schema, leave it alone
		return schema\|\| null;
		return schema?? null;
		}