Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: enable prefer-nullish-coalescing internally#7955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Fixes up most of the last few violations of@typescript-eslint/prefer-nullish-coalescing. Ignores primitives because we tend to do "fun" things with strings.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlifyNetlify
Copy link

netlifybot commentedNov 19, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit3c7f9b9
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/65b1153e317e0f00080ef992
😎 Deploy Previewhttps://deploy-preview-7955--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 96 (🟢 up 6 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@JoshuaKGoldbergJoshuaKGoldberg marked this pull request as ready for reviewNovember 29, 2023 00:40
@bradzacherbradzacher changed the titlechore: enable prefer-nullish-calescing internallychore: enable prefer-nullish-coalescing internallyJan 13, 2024
Copy link
Member

@bradzacherbradzacher left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can we turn it on withignoreConditionalTests?
I think that using?? in conditional tests is less clear.

Consider the downlevelled output:

if(x||y){}// vsif(x??y){}// downlevelled toif(x!=null ?x :y){}

I think it's a whole lot less clear.
Actually I'm going to go as far as advocating for flipping the default in v7 -#8243

@bradzacherbradzacher added repo maintenancethings to do with maintenance of the repo, and not with code/docs awaiting responseIssues waiting for a reply from the OP or another party labelsJan 13, 2024
@bradzacherbradzacher removed the awaiting responseIssues waiting for a reply from the OP or another party labelJan 27, 2024
@bradzacherbradzacher added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelJan 28, 2024
@JoshuaKGoldbergJoshuaKGoldberg merged commitd0137c8 intotypescript-eslint:mainJan 28, 2024
@JoshuaKGoldbergJoshuaKGoldberg deleted the lint-enable-prefer-nullish-coalescing branchJanuary 28, 2024 07:40
danvk pushed a commit to danvk/typescript-eslint that referenced this pull requestFeb 4, 2024
…#7955)* chore: enable prefer-nullish-calescing internally* A couple complaints* One last complaint* Enable ignoreConditionalTests
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsFeb 5, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we mergerepo maintenancethings to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@JoshuaKGoldberg@bradzacher
[8]ページ先頭
©2009-2025 Movatter.jp