Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(eslint-plugin): [ban-ts-comments] suggest ts-expect-error over ts-ignore#7849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

NotWoods
Copy link
Contributor

@NotWoodsNotWoods commentedOct 27, 2023•
edited by JoshuaKGoldberg
Loading

PR Checklist

Overview

Updates error message and adds a suggestion to replace ts-ignore with ts-expect-error, as long as the option for banning ts-expect-error is not set to true.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@NotWoods!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedOct 27, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit0a64ad1
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/65400c92c769220008c9833f
😎 Deploy Previewhttps://deploy-preview-7849--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		1 paths audited
Performance: 90 (🔴 down 8 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloud
Copy link

nx-cloudbot commentedOct 27, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit0a64ad1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 19 targets

Sent with 💌 fromNxCloud.

Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks great overall - and love the thorough tests! Just the one point, what do you think?

@JoshuaKGoldbergJoshuaKGoldberg added the awaiting responseIssues waiting for a reply from the OP or another party labelOct 30, 2023
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Cartoonish skeleton with an oversized glowing jack-o-lantern head, dancing in a nighttime cemetery

@JoshuaKGoldbergJoshuaKGoldberg removed the awaiting responseIssues waiting for a reply from the OP or another party labelOct 30, 2023
@JoshuaKGoldbergJoshuaKGoldberg merged commit5e73a48 intotypescript-eslint:mainOct 30, 2023
@NotWoodsNotWoods deleted the ts-ignore-suggestion branchOctober 31, 2023 01:57
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsNov 8, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: [ban-ts-comment] Autofix ts-ignore to ts-expect-error depending on options
2 participants
@NotWoods@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp