Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(eslint-plugin): [naming-convention] allow PascalCase for imports#7841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Adds'PascalCase' alongside'camelCase' to the allowed formats for imports. This should allow the majority of community standards, such asimport * as React from "react".

Funny that out of the >15,000 (!) generated unit tests for this rule, none were impacted by this change to defaults.

titouandk reacted with thumbs up emojikarlhorky and booklista-yao reacted with heart emoji
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedOct 26, 2023
edited
Loading

Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit5df017f
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/653a369b6bcbda0008fade21
😎 Deploy Previewhttps://deploy-preview-7841--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloud
Copy link

nx-cloudbot commentedOct 26, 2023
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit5df017f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 19 targets

Sent with 💌 fromNxCloud.

@JoshuaKGoldbergJoshuaKGoldberg merged commit7ad86ee intotypescript-eslint:mainOct 26, 2023
@JoshuaKGoldbergJoshuaKGoldberg deleted the naming-convention-default-options-import-pascal-too branchOctober 26, 2023 14:25
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsNov 3, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bradzacherbradzacherbradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [naming-convention] Defaultimport config clashes with common npm import patterns (PascalCase and other-cased imports)
2 participants
@JoshuaKGoldberg@bradzacher

[8]ページ先頭

©2009-2025 Movatter.jp