Makes progress on fixing existing@typescript-eslint/no-unnecessary-condition violations underpackages/typescript-estree. Part of a series of PRs that split this up, as there are many of them.

chore(typescript-estree): fixed no-unnecessary-condition complaints

b1c4099

Copy link

Contributor

typescript-eslintbot commentedOct 25, 2023

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedOct 25, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`11884da`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6551619722be1c0008546d7d
😎 Deploy Preview	https://deploy-preview-7835--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 90 (🔴 down 9 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Copy link

nx-cloudbot commentedOct 25, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commitc7775df. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 19 targets

Sent with 💌 fromNxCloud.

Removed now-unnecessary disables

c7775df

JoshuaKGoldberg marked this pull request as ready for review

October 31, 2023 19:35

bradzacher added the repo maintenancethings to do with maintenance of the repo, and not with code/docs label

Nov 10, 2023

bradzacher reviewed

Nov 10, 2023

View reviewed changes

packages/typescript-estree/src/parseSettings/warnAboutTSVersion.ts Outdated

		@@ -25,8 +25,7 @@ let warnedAboutTSVersion = false;

		export function warnAboutTSVersion(parseSettings: ParseSettings): void {
		if (!isRunningSupportedTypeScriptVersion && !warnedAboutTSVersion) {
		const isTTY =
		typeof process === 'undefined' ? false : process.stdout?.isTTY;
		const isTTY = typeof process === 'undefined' ? false : process.stdout.isTTY;

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

IIRC this is actually necessary
#1619

Copy link

MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🤔 I don't like adding support for something that's not possible per type definitions...process.stdout is supposed to exist. If some bundler removes it then they're telling a lie to packages like us. Hmm.#7896

Copy link

Member

bradzacherNov 12, 2023•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yeah generally I'd say "I don't care" if someone's playing funny-buggers like that -- but the reason we accepted it was because it's prettier and they're one of our biggest consumers and we ❤️ them

Copy link

MemberAuthor

JoshuaKGoldbergNov 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I do ❤️ Prettier 😄

bradzacher added the awaiting responseIssues waiting for a reply from the OP or another party label

Nov 10, 2023

JoshuaKGoldberg mentioned this pull request

Nov 11, 2023

Repo: Update our types to reflect process.stdout possibly being undefined#7896

Open

ease up on process.stdout

1675163

JoshuaKGoldberg mentioned this pull request

Nov 11, 2023

Repo: Builds stalled and broken on main for the checkout phase?#7899

Closed

bradzacher added 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge and removed awaiting responseIssues waiting for a reply from the OP or another party labels

Nov 12, 2023