Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

docs: reference eslint-stylistic around formatting docs#7733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Applies a few touchups to theWhat About Formatting? page:

  • Removes the wordstrongly to tone down the severity a bit
  • Adds a more explicit mention of typed rules making the performance penalty of re-running linting more severe
    • As I think@Josh-Cena has mentioned previously, much of this docs page really is an ESLint core thing. I want to be clear in it about anything that is different for us.
  • Adds a link toeslint.style, with an explanation of why you'd use it

Also changes the auto-generated admonition on top of formatting rules to point toeslint.style.

cc@antfu - if you have the time, I'd greatly appreciate your review on this. Is this wording accurate and not too harsh still? Is there more reasoning you'd want to add for using eslint.style instead of a dedicated formatter? Is there anywhere else you think we should add something?

levchak0910 reacted with thumbs up emojiantfu reacted with heart emoji
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedOct 10, 2023
edited
Loading

Deploy Preview fortypescript-eslint ready!

NameLink
🔨 Latest commit52cdfb7
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/652efa7cae65980008553171
😎 Deploy Previewhttps://deploy-preview-7733--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🟢 up 4 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

@nx-cloud
Copy link

nx-cloudbot commentedOct 10, 2023
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit52cdfb7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 19 targets

Sent with 💌 fromNxCloud.

Copy link
Contributor

@antfuantfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks great! Thanks a lot for the support! (and working on it so quickly!) 💚

JoshuaKGoldberg reacted with heart emoji
@JamesHenry
Copy link
Member

FYI I reran your failed deploy without the cache via the Netlify UI which resolved the issue:
image

@JoshuaKGoldbergJoshuaKGoldberg merged commit3f64baa intotypescript-eslint:mainOct 19, 2023
@JoshuaKGoldbergJoshuaKGoldberg deleted the eslint-stylistic-docs branchOctober 19, 2023 17:33
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsOct 27, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@antfuantfuantfu approved these changes

@Josh-CenaJosh-CenaJosh-Cena approved these changes

@bradzacherbradzacherAwaiting requested review from bradzacher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: Mention eslint-stylistic (eslint.style)
4 participants
@JoshuaKGoldberg@JamesHenry@antfu@Josh-Cena

[8]ページ先頭

©2009-2025 Movatter.jp