fix(eslint-plugin): [no-shadow] fix static class generics for class expressions#7724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JoshuaKGoldberg merged 4 commits intotypescript-eslint:mainfrompeanutenthusiast:fix/7664/fix-static-class-generics-for-class-expressions

Oct 11, 2023

Merged

fix(eslint-plugin): [no-shadow] fix static class generics for class expressions#7724

JoshuaKGoldberg merged 4 commits intotypescript-eslint:mainfrompeanutenthusiast:fix/7664/fix-static-class-generics-for-class-expressions

Oct 11, 2023

Conversation

Copy link

Contributor

peanutenthusiast commentedOct 5, 2023

PR Checklist

Addresses an existing open issue:fixesBug: [no-shadow] 'T' in static method is already declared in upper scope when class is in a factory function #7664
That issue was marked asaccepting prs
Steps inContributing were taken

Overview

This PR adds an extra check for whether the parent of a type parameter declaration is a Class Expression

peanutenthusiast added2 commits

September 18, 2023 18:05

Add test for factory generating class functionn with generic type

6e02253

Rename isGenericOfClassDecl to isGenericOfClass, check for class expr…

34d5905

…ession in function

Copy link

Contributor

typescript-eslintbot commentedOct 5, 2023

Thanks for the PR,@peanutenthusiast!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedOct 5, 2023•
edited
Loading

❌ Deploy Preview fortypescript-eslint failed.

Name	Link
🔨 Latest commit	`0cdc6d5`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6524c442d740ee0008977f36

Copy link

nx-cloudbot commentedOct 5, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit0cdc6d5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 20 targets