Ideally I should use an actual parser to get thedefaultTypes, but there's no parser package readily installed in the website, so I thought this should do too.

Copy link

Contributor

typescript-eslintbot commentedOct 1, 2023

Thanks for the PR,@Josh-Cena!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlifybot commentedOct 1, 2023•
edited
Loading

✅ Deploy Preview fortypescript-eslint ready!

Name	Link
🔨 Latest commit	`3427afb`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/653162bd25cd9c0008f7ef4a
😎 Deploy Preview	https://deploy-preview-7714--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 95 (no change from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to yourNetlify site configuration.

Josh-Cena requested a review fromJoshuaKGoldberg

October 1, 2023 19:25

refactor(website): auto-inject ban-types default options

d6054fa

Josh-Cena force-pushed theinject-ban-types-default branch from03994ba tod6054faCompare

October 1, 2023 19:26

Copy link

nx-cloudbot commentedOct 1, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit3427afb. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 19 targets

Sent with 💌 fromNxCloud.

JoshuaKGoldberg reviewed

Oct 8, 2023

View reviewed changes

packages/website/plugins/generated-rule-docs.ts

		}

		// Insert default rule options for ban-types
		if(file.stem==='ban-types'){

Copy link

Member

JoshuaKGoldbergOct 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

😬 I do dislike having such rule-specific things in this already kind of big file... what do you think about having an mdx component like<BanTypesDefaultOptions />?

Copy link

MemberAuthor

Josh-CenaOct 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We already have file-specific handling for this page. This cannot be an MDX component because it has to work server-side and get statically injected instead of dynamically rendered.

Copy link

Member

JoshuaKGoldbergOct 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Blurgh, I keep forgetting these things. MDX components don't work server-side? Is this mentioned in docs / one of the things blocked by MDX v2? (I searched and can't find it)

Copy link

MemberAuthor

Josh-CenaOct 9, 2023•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

MDX components are basically React components. They can get server-rendered (through the same machinery that renders the rest of the page to HTML) but they can't access server data like files.