Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

docs: fix prefer-optional-chain example for the unsafe fixes option#7711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

cigui
Copy link
Contributor

…odifyTheReturnTypeIKnowWhatImDoing in prefer-optional-chain

PR Checklist

Overview

The example for the option allowPotentiallyUnsafeFixesThatModifyTheReturnTypeIKnowWhatImDoing seems like a copy-paste error, which has two equal lines callingacceptsBoolean. The second line should be using optional chain.

…odifyTheReturnTypeIKnowWhatImDoing in prefer-optional-chain
@typescript-eslint
Copy link
Contributor

Thanks for the PR,@cigui!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@netlify
Copy link

netlifybot commentedOct 1, 2023•
edited
Loading

❌ Deploy Preview fortypescript-eslint failed.

NameLink
🔨 Latest commit395afa6
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/65198a8d466dad00072ec667

@nx-cloud
Copy link

nx-cloudbot commentedOct 1, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit395afa6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 20 targets

Sent with 💌 fromNxCloud.

@JoshuaKGoldbergJoshuaKGoldberg changed the titledocs: fix the example for the option allowPotentiallyUnsafeFixesThatM…docs: fix prefer-optional-chain example for the unsafe fixes optionOct 8, 2023
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Agreed 😄 thanks!

@JoshuaKGoldbergJoshuaKGoldberg merged commit8f4d939 intotypescript-eslint:mainOct 8, 2023
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsOct 16, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: [prefer-optional-chain] update docs for the option allowPotentiallyUnsafeFixesThatModifyTheReturnTypeIKnowWhatImDoing
2 participants
@cigui@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp