Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(eslint-plugin): [no-unsafe-return] allow returning anything if explicitly returning any#7708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

Josh-Cena
Copy link
Member

@Josh-CenaJosh-Cena commentedOct 1, 2023•
edited
Loading

PR Checklist

Overview

I'm not sure if we should handle the following case:const x: () => any = () => [] as any[];

Overall the docs does not make it clear which cases are exempted, so I guess we have some room for interpretation.

@typescript-eslint
Copy link
Contributor

Thanks for the PR,@Josh-Cena!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently onhttps://opencollective.com/typescript-eslint.

@Josh-CenaJosh-Cena changed the titlefix(eslint-plugin): [no-unsafe-return] allow returning anything if ex…fix(eslint-plugin): [no-unsafe-return] allow returning anything if explicitly returning anyOct 1, 2023
@netlify
Copy link

netlifybot commentedOct 1, 2023•
edited
Loading

❌ Deploy Preview fortypescript-eslint failed.

NameLink
🔨 Latest commite677bb7
🔍 Latest deploy loghttps://app.netlify.com/sites/typescript-eslint/deploys/65202deaf368190008ee5522

@nx-cloud
Copy link

nx-cloudbot commentedOct 1, 2023•
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commite677bb7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 20 targets

Sent with 💌 fromNxCloud.

JoshuaKGoldberg
JoshuaKGoldberg previously approved these changesOct 6, 2023
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍 very reasonable!

function foo(): any {
return [] as any[];
}
`,
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldbergOct 6, 2023•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

[Testing] Could you add a test forunknown too?

some room for interpretation.

Yeah I think this is fine as-is for now. If folks really give solid use-cases for the more complex ones we can always look into adding more complexity.

@JoshuaKGoldbergJoshuaKGoldberg added the 1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labelOct 6, 2023
Copy link
Member

@JoshuaKGoldbergJoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

🚀

@JoshuaKGoldbergJoshuaKGoldberg merged commitc6124b2 intotypescript-eslint:mainOct 19, 2023
@Josh-CenaJosh-Cena deleted the no-unsafe-return-explicit-any branchOctober 19, 2023 07:13
@github-actionsgithub-actionsbot locked asresolvedand limited conversation to collaboratorsOct 27, 2023
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@JoshuaKGoldbergJoshuaKGoldbergJoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
1 approval>=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[no-unsafe-return] does not allow return any[] when function is typed asany
2 participants
@Josh-Cena@JoshuaKGoldberg
[8]ページ先頭
©2009-2025 Movatter.jp